Re: svn commit: r597665 - /incubator/stdcxx/branches/4.2.x/include/streambuf

[Martin Sebor <se...@roguewave.com>]

faridz@apache.org wrote:
> Author: faridz
> Date: Fri Nov 23 05:51:51 2007
> New Revision: 597665
> 
> URL: http://svn.apache.org/viewvc?rev=597665&view=rev
> Log:
> 2007-11-23 Farid Zaripov <fa...@epam.com>
> 
> 	STDCXX-307
> 	* streambuf (imbue): Code storing the locale moved from here...
> 	(pubimbue): ... to here.
> 
> Modified:
>     incubator/stdcxx/branches/4.2.x/include/streambuf
> 
> Modified: incubator/stdcxx/branches/4.2.x/include/streambuf
> URL: http://svn.apache.org/viewvc/incubator/stdcxx/branches/4.2.x/include/streambuf?rev=597665&r1=597664&r2=597665&view=diff
> ==============================================================================
> --- incubator/stdcxx/branches/4.2.x/include/streambuf (original)
> +++ incubator/stdcxx/branches/4.2.x/include/streambuf Fri Nov 23 05:51:51 2007
> @@ -248,7 +248,7 @@
>  
>      // 27.5.2.4.1, p1
>      virtual void imbue (const locale &__loc) {

The name of the argument should be removed if it's not used,
otherwise some compilers will complain. From the recent HP
aCC log:

http://people.apache.org/~sebor/stdcxx/results/hpux-11.23-pa-acc-3.73-8s-597671-log.gz.txt

aCC -c     -I$(TOPDIR)/include -I$(BUILDDIR)/include  -AA  +O2   +w 
+W392 +W655 +W684 +W818 +W819 +W849    $(TOPDIR)/src/strstream.cpp
Warning (suggestion) 431: "$(TOPDIR)/include/streambuf", line 250 # No 
uses of '__loc' were detected; it may be possible to remove its declaration.
         virtual void imbue (const locale &__loc) {
                                           ^^^^^

Martin

> -        _C_locale = __loc;
> +        // do nothing
>      }
>  
>      // 27.5.2.4.2, p1
> @@ -496,6 +496,7 @@
>  
>      const locale __tmp (getloc ());
>      imbue (__loc);
> +    _C_locale = __loc;
>      return __tmp;
>  }
>  
> 
>