You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/14 17:22:12 UTC
[GitHub] [incubator-superset] kkucharc opened a new pull request #10877: [WIP] Reviewed and repaired disabled pylint in dashboard file
kkucharc opened a new pull request #10877:
URL: https://github.com/apache/incubator-superset/pull/10877
### SUMMARY
Changed easy-to-fix pylint disabled rules in `dashboard.py`:
- `unused-argument`
- `broad-except`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10877: [WIP] Reviewed and repaired disabled pylint in dashboard file
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10877:
URL: https://github.com/apache/incubator-superset/pull/10877#issuecomment-692202067
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=h1) Report
> Merging [#10877](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/782f678732be43de67f6d225e944856c5dcd7b18?el=desc) will **decrease** coverage by `4.81%`.
> The diff coverage is `62.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10877 +/- ##
==========================================
- Coverage 65.40% 60.59% -4.82%
==========================================
Files 802 380 -422
Lines 37872 24060 -13812
Branches 3561 0 -3561
==========================================
- Hits 24771 14579 -10192
+ Misses 12997 9481 -3516
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.59% <62.50%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <62.50%> (-0.28%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.36% <0.00%> (-3.68%)` | :arrow_down: |
| [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `71.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-2.70%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [456 more](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=footer). Last update [782f678...4966861](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc commented on pull request #10877: [WIP] Reviewed and repaired disabled pylint in dashboard file
Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10877:
URL: https://github.com/apache/incubator-superset/pull/10877#issuecomment-692673827
@willbarrett Thank you for the review. There were Cypress (generating Codecov) and black problems. I applied black and pushed new commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10877: [WIP] Reviewed and repaired disabled pylint in dashboard file
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10877:
URL: https://github.com/apache/incubator-superset/pull/10877#issuecomment-692202067
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=h1) Report
> Merging [#10877](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38edb69d95a79e8507db7cdff431565215bcbda0?el=desc) will **decrease** coverage by `2.26%`.
> The diff coverage is `62.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10877 +/- ##
==========================================
- Coverage 61.35% 59.09% -2.27%
==========================================
Files 380 776 +396
Lines 24083 37060 +12977
Branches 0 3310 +3310
==========================================
+ Hits 14777 21900 +7123
- Misses 9306 14969 +5663
- Partials 0 191 +191
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.88% <ø> (?)` | |
| #python | `61.35% <62.50%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <62.50%> (-0.28%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwuanN4) | `72.72% <0.00%> (ø)` | |
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `50.00% <0.00%> (ø)` | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `92.59% <0.00%> (ø)` | |
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `65.90% <0.00%> (ø)` | |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `42.85% <0.00%> (ø)` | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | `87.50% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <0.00%> (ø)` | |
| [.../src/explore/components/MetricDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uT3B0aW9uLmpzeA==) | `81.81% <0.00%> (ø)` | |
| ... and [387 more](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=footer). Last update [38edb69...3eaa4c2](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett merged pull request #10877: Reviewed and repaired disabled pylint in dashboard file
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #10877:
URL: https://github.com/apache/incubator-superset/pull/10877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10877: [WIP] Reviewed and repaired disabled pylint in dashboard file
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10877:
URL: https://github.com/apache/incubator-superset/pull/10877#issuecomment-692202067
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=h1) Report
> Merging [#10877](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/782f678732be43de67f6d225e944856c5dcd7b18?el=desc) will **decrease** coverage by `4.76%`.
> The diff coverage is `62.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10877 +/- ##
==========================================
- Coverage 65.40% 60.64% -4.77%
==========================================
Files 802 380 -422
Lines 37872 24060 -13812
Branches 3561 0 -3561
==========================================
- Hits 24771 14590 -10181
+ Misses 12997 9470 -3527
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.64% <62.50%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <62.50%> (-0.28%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.36% <0.00%> (-3.68%)` | :arrow_down: |
| [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `71.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-2.70%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.39%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/10877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=footer). Last update [782f678...4966861](https://codecov.io/gh/apache/incubator-superset/pull/10877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org