You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/13 07:48:46 UTC
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich opened a new issue, #19: Revisit usage of `pekko_` schema prefix
mdedetrich opened a new issue, #19:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/19
One thing I noticed that this plugin using the `pekko_` (formerly `akka_`) prefix for schema is in contrast to https://github.com/apache/incubator-pekko-persistence-jdbc which doesn't have any such schema. Maybe we should have a look into removing the prefix entirely and as an added bonus this might make this plugin compatible with https://github.com/apache/incubator-pekko-persistence-jdbc since the schema would be the same (giving people an easy upgrade path from JDBC to r2dbc without any migration).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Revisit usage of `pekko_` schema prefix? [incubator-pekko-persistence-r2dbc]
Posted by "danischroeter (via GitHub)" <gi...@apache.org>.
danischroeter commented on issue #19:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/19#issuecomment-1843275127
@mdedetrich
I just checked if we could make this plugin compatible with https://github.com/apache/incubator-pekko-persistence-jdbc
This is not possible. The schemas although similar are fundamentally different - especially related to tags.
jdbc stores tags in a separate table `event_tag` vs r2dbc uses `tags TEXT ARRAY` in the `event_journal` table.
The two plugins are essentially incompatible and must use different schemas. One can use the migration tool to convert from jdbc to r2dbc. See https://pekko.apache.org/docs/pekko-persistence-r2dbc/current/migration.html
I think I will add a note to the schema documentation to make this incompatibility obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Revisit usage of `pekko_` schema prefix? [incubator-pekko-persistence-r2dbc]
Posted by "danischroeter (via GitHub)" <gi...@apache.org>.
danischroeter commented on issue #19:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/19#issuecomment-1840579116
@mdedetrich Sure. I'll look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Revisit usage of `pekko_` schema prefix? [incubator-pekko-persistence-r2dbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #19:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/19#issuecomment-1839801440
@danischroeter Are you interested in looking into this? We are contemplating doing a release of persistence-r2dbc soon and being a schema change it makes sense to fix this before an initial release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] danischroeter commented on issue #19: Revisit usage of `pekko_` schema prefix?
Posted by "danischroeter (via GitHub)" <gi...@apache.org>.
danischroeter commented on issue #19:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/19#issuecomment-1506646772
@mdedetrich I think the prefix should be removed. It does not add value and is inconsistent. Persistence-cassandra also does not have a prefix. E.g journal table just called `messages` see
https://github.com/apache/incubator-pekko-persistence-cassandra/blob/main/core/src/main/scala/org/apache/pekko/persistence/cassandra/journal/CassandraJournalStatements.scala
https://github.com/apache/incubator-pekko-persistence-cassandra/blob/main/core/src/main/resources/reference.conf#L105
More interestingly most tables do not have a prefix - just projection
see https://github.com/apache/incubator-pekko-persistence-r2dbc/blob/main/ddl-scripts/create_tables_postgres.sql
```
DROP TABLE IF EXISTS event_journal;
DROP TABLE IF EXISTS snapshot;
DROP TABLE IF EXISTS durable_state;
DROP TABLE IF EXISTS pekko_projection_offset_store;
DROP TABLE IF EXISTS pekko_projection_timestamp_offset_store;
DROP TABLE IF EXISTS pekko_projection_management;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on issue #19: Revisit usage of `pekko_` schema prefix
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #19:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/19#issuecomment-1506512807
@nvollmar @spangaer @danischroeter I think you use persistence in production so maybe you can comment on this? (Also feel free to ping anyone else that may also be using it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Revisit usage of `pekko_` schema prefix? [incubator-pekko-persistence-r2dbc]
Posted by "danischroeter (via GitHub)" <gi...@apache.org>.
danischroeter closed issue #19: Revisit usage of `pekko_` schema prefix?
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on issue #19: Revisit usage of `pekko_` schema prefix?
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #19:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/19#issuecomment-1506652581
In that case I would say there is merit in doing this as well as making the schema consistent with https://github.com/apache/incubator-pekko-persistence-jdbc since they both deal with SQL/SQL like databases. Since we have to do a migration anyways I think there is an argument that it can be released with v1.0.0 if someone implements this before the release is made (that way we don't need another migration for v1.1.x)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Revisit usage of `pekko_` schema prefix? [incubator-pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #19:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/19#issuecomment-1791714900
@mdedetrich what do you think we should do here? We're close enough to being able to consider an RC for this module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org