[kudu-CR] external mini cluster: allow more flags on restart

["Andrew Wong (Code Review)" <ge...@cloudera.org>]

Andrew Wong has posted comments on this change.

Change subject: external_mini_cluster: allow more flags on restart
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7242/4/src/kudu/integration-tests/external_mini_cluster.h
File src/kudu/integration-tests/external_mini_cluster.h:

PS4, Line 437:   // Return a pointer to the flags used for this server on restart.
             :   // Modifying these flags will only take effect on the next restart.
             :   std::vector<std::string>* mutable_flags() { return &extra_flags_; }
> Doesn't this method allow you to do what you want already?
Yep, looks like it. Thanks


-- 
To view, visit http://gerrit.cloudera.org:8080/7242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa588eab70880ffb8680097ef7f4292e2f638fed
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes