You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/08 10:42:16 UTC
[GitHub] [flink] humengyu2012 opened a new pull request #15113: [FLINK-21665] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
humengyu2012 opened a new pull request #15113:
URL: https://github.com/apache/flink/pull/15113
## What is the purpose of the change
This pull request supports create catalog by CREATE CATALOG catalog_name [COMMENT catalog_comment] [WITH (property_name=property_value, ...)] syntax.
## Brief change log
- Support syntax in flink parser.
## Verifying this change
- Added tests in FlinkSqlParserImplTest to verify syntax support.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: np
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15113: [FLINK-21665] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792672390
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297",
"triggerID" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4cf9033eca56b5532021c9f96bf2ac59e738e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] humengyu2012 closed pull request #15113: [FLINK-21665][Table] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
humengyu2012 closed pull request #15113:
URL: https://github.com/apache/flink/pull/15113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15113: [FLINK-21665] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792672390
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4cf9033eca56b5532021c9f96bf2ac59e738e88 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15113: [FLINK-21665][Table] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792672390
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297",
"triggerID" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"triggerType" : "PUSH"
}, {
"hash" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"triggerType" : "PUSH"
}, {
"hash" : "ae3776ea77d9b88f42f5829583a1c2e0dca60511",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14341",
"triggerID" : "ae3776ea77d9b88f42f5829583a1c2e0dca60511",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4cf9033eca56b5532021c9f96bf2ac59e738e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297)
* 134b90b025752fbe9b45cc48b4b93cbeb9de9142 UNKNOWN
* ae3776ea77d9b88f42f5829583a1c2e0dca60511 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #15113: [FLINK-21665][Table] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-968844234
@humengyu2012 Can you let me know what you think is the status of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15113: [FLINK-21665][Table] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792672390
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297",
"triggerID" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"triggerType" : "PUSH"
}, {
"hash" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4cf9033eca56b5532021c9f96bf2ac59e738e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297)
* 134b90b025752fbe9b45cc48b4b93cbeb9de9142 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] humengyu2012 commented on pull request #15113: [FLINK-21665] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
humengyu2012 commented on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792747416
Thanks, I will continue to improve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15113: [FLINK-21665][Table] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792672390
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297",
"triggerID" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"triggerType" : "PUSH"
}, {
"hash" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"triggerType" : "PUSH"
}, {
"hash" : "ae3776ea77d9b88f42f5829583a1c2e0dca60511",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14341",
"triggerID" : "ae3776ea77d9b88f42f5829583a1c2e0dca60511",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 134b90b025752fbe9b45cc48b4b93cbeb9de9142 UNKNOWN
* ae3776ea77d9b88f42f5829583a1c2e0dca60511 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #15113: [FLINK-21665] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792727718
We can't merge this as this is not a full feature. This only support parsing syntax in sql-parser. Please also support in `TableEnvironment`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] humengyu2012 commented on pull request #15113: [FLINK-21665][Table] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
humengyu2012 commented on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-968867846
This PR has been over too long, resulting in many conflicts that could not be resolved, I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15113: [FLINK-21665] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792665353
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b4cf9033eca56b5532021c9f96bf2ac59e738e88 (Mon Mar 08 10:43:56 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21665).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15113: [FLINK-21665][Table] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792672390
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297",
"triggerID" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"triggerType" : "PUSH"
}, {
"hash" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"triggerType" : "PUSH"
}, {
"hash" : "ae3776ea77d9b88f42f5829583a1c2e0dca60511",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14341",
"triggerID" : "ae3776ea77d9b88f42f5829583a1c2e0dca60511",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 134b90b025752fbe9b45cc48b4b93cbeb9de9142 UNKNOWN
* ae3776ea77d9b88f42f5829583a1c2e0dca60511 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15113: [FLINK-21665][Table] Support [IF NOT EXISTS] and [COMMENT] for create catalog statement
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15113:
URL: https://github.com/apache/flink/pull/15113#issuecomment-792672390
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297",
"triggerID" : "b4cf9033eca56b5532021c9f96bf2ac59e738e88",
"triggerType" : "PUSH"
}, {
"hash" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "134b90b025752fbe9b45cc48b4b93cbeb9de9142",
"triggerType" : "PUSH"
}, {
"hash" : "ae3776ea77d9b88f42f5829583a1c2e0dca60511",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae3776ea77d9b88f42f5829583a1c2e0dca60511",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4cf9033eca56b5532021c9f96bf2ac59e738e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14297)
* 134b90b025752fbe9b45cc48b4b93cbeb9de9142 UNKNOWN
* ae3776ea77d9b88f42f5829583a1c2e0dca60511 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org