You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/11/28 00:27:37 UTC
[GitHub] wohali commented on a change in pull request #1764: Switch scripts
to python3
wohali commented on a change in pull request #1764: Switch scripts to python3
URL: https://github.com/apache/couchdb/pull/1764#discussion_r236900389
##########
File path: Makefile
##########
@@ -280,7 +280,11 @@ build-test:
.PHONY: mango-test
# target: mango-test - Run Mango tests
mango-test: devclean all
- @cd src/mango && ../../dev/run -n 1 --admin=testuser:testpass nosetests
+ @cd src/mango && \
+ virtualenv --python=python3 venv && \
+ . ./venv/bin/activate && \
Review comment:
@nickva I'm going to remove use of the `activate` script in Makefile and install just directly call `venv/bin/pip3`. I had to do something similar on Windows (because of how make + batchfile chaining worked) and I think it's cleaner to read anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services