You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Shawn McKinney (JIRA)" <ji...@apache.org> on 2016/01/09 01:12:39 UTC
[jira] [Commented] (FC-135) Rename ambigous getter and setters
names on User and UserAdminRole
[ https://issues.apache.org/jira/browse/FC-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090248#comment-15090248 ]
Shawn McKinney commented on FC-135:
-----------------------------------
Pull Request received:
GitHub user pike1212 opened a pull request:
https://github.com/apache/directory-fortress-core/pull/4
Rename Set Methods to avoid Conflict
I renamed the duplicate set methods. My junit tests don't work even before I made the change, so not sure how to propertly test. This is the error I get when running "mvn test -Dtest=FortressJUnitTest"
Tests run: 141, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 228.481 sec <<< FAILURE! - in org.apache.directory.fortress.core.impl.FortressJUnitTest
testSearchBinds(org.apache.directory.fortress.core.impl.AuditMgrImplTest) Time elapsed: 0.022 sec <<< FAILURE!
junit.framework.AssertionFailedError: org.apache.directory.fortress.core.impl.AuditMgrImplTestsearchBinds failed search for successful authentication user [jtsUser1]
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.TestCase.assertTrue(TestCase.java:192)
at org.apache.directory.fortress.core.impl.AuditMgrImplTest.searchBinds(AuditMgrImplTest.java:426)
at org.apache.directory.fortress.core.impl.AuditMgrImplTest.testSearchBinds(AuditMgrImplTest.java:399)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PennState/directory-fortress-core-1 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/directory-fortress-core/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 1e664a2e49b65c33e323e43beba88c0816601076
Author: clp207 <cl...@psu.edu>
Date: 2016-01-05T17:01:31Z
renamed set methods with same name in models
commit 417dc4d23858a059306f3a1d5b3f0588e71f74f3
Author: clp207 <cl...@psu.edu>
Date: 2016-01-05T18:12:31Z
changed method name to have List isntead of 's'
commit eae93c8ff3eb1f2b7e556ff35191a06fa4b30564
Author: clp207 <cl...@psu.edu>
Date: 2016-01-05T18:21:14Z
fixed test classes
----
> Rename ambigous getter and setters names on User and UserAdminRole
> ------------------------------------------------------------------
>
> Key: FC-135
> URL: https://issues.apache.org/jira/browse/FC-135
> Project: FORTRESS
> Issue Type: Improvement
> Affects Versions: 1.0.0-RC40
> Reporter: Shawn McKinney
> Fix For: 1.0.0-RC41
>
>
> Ticket was a request from Chris Pike:
> On Jan 5, 2016, at 10:35 AM, Chris Pike <cl...@psu.edu> wrote:
> There are a couple instances where models have multiple set methods for the same field.
> UserAdminRole has...
> public void setOsP( String osP )
> public void setOsP( Set<String> osPs )
> public void setOsU( Set<String> osUs )
> public void setOsU( String osU )
> User has...
> public void setRole( String roleName )
> public void setRole( UserRole role )
> public void setAdminRole( UserAdminRole role )
> public void setAdminRole( String roleName )
> This is causing some issues down the line with jackson. I have a workaround but wanted to see if there was any possibility of changing one of the method names.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)