You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/14 20:23:20 UTC
[kudu-CR](branch-1.11.x) www: ensure all href values are enclosed in single or double quotes
Hello Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14430
to review the following change.
Change subject: www: ensure all href values are enclosed in single or double quotes
......................................................................
www: ensure all href values are enclosed in single or double quotes
AFAICT this was the only exception, an oversight from the original mustache
conversion done back in commit 107b9cdf8.
I used a local Kudu master to verify the change in the emitted HTML, and
followed a couple links in the browser to make sure everything still worked.
Change-Id: Ib1b9cc8f97390617d6b0a6e183081483ca7ad6a0
Reviewed-on: http://gerrit.cloudera.org:8080/14429
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit e516347d7010f1d033d8cc44ec6d3c964e204d63)
---
M www/home.mustache
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/14430/1
--
To view, visit http://gerrit.cloudera.org:8080/14430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1b9cc8f97390617d6b0a6e183081483ca7ad6a0
Gerrit-Change-Number: 14430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) www: ensure all href values are enclosed in single or double quotes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: www: ensure all href values are enclosed in single or double quotes
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib1b9cc8f97390617d6b0a6e183081483ca7ad6a0
Gerrit-Change-Number: 14430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) www: ensure all href values are enclosed in single or double quotes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14430 )
Change subject: www: ensure all href values are enclosed in single or double quotes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1b9cc8f97390617d6b0a6e183081483ca7ad6a0
Gerrit-Change-Number: 14430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Oct 2019 23:47:09 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) www: ensure all href values are enclosed in single or double quotes
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14430 )
Change subject: www: ensure all href values are enclosed in single or double quotes
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1b9cc8f97390617d6b0a6e183081483ca7ad6a0
Gerrit-Change-Number: 14430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Oct 2019 20:49:00 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) www: ensure all href values are enclosed in single or double quotes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14430 )
Change subject: www: ensure all href values are enclosed in single or double quotes
......................................................................
www: ensure all href values are enclosed in single or double quotes
AFAICT this was the only exception, an oversight from the original mustache
conversion done back in commit 107b9cdf8.
I used a local Kudu master to verify the change in the emitted HTML, and
followed a couple links in the browser to make sure everything still worked.
Change-Id: Ib1b9cc8f97390617d6b0a6e183081483ca7ad6a0
Reviewed-on: http://gerrit.cloudera.org:8080/14429
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit e516347d7010f1d033d8cc44ec6d3c964e204d63)
Reviewed-on: http://gerrit.cloudera.org:8080/14430
Reviewed-by: Greg Solovyev <gs...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M www/home.mustache
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Greg Solovyev: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1b9cc8f97390617d6b0a6e183081483ca7ad6a0
Gerrit-Change-Number: 14430
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) www: ensure all href values are enclosed in single or double quotes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14430 )
Change subject: www: ensure all href values are enclosed in single or double quotes
......................................................................
Patch Set 1: Verified+1
Transient error while fetching from http://gerrit.cloudera.org:
git fetch --tags --progress http://gerrit.cloudera.org/kudu refs/changes/30/14430/1
(HTTP code 502 internal server error)
I retried it at 14:48 PDT and it worked fine.
--
To view, visit http://gerrit.cloudera.org:8080/14430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1b9cc8f97390617d6b0a6e183081483ca7ad6a0
Gerrit-Change-Number: 14430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Oct 2019 21:49:33 +0000
Gerrit-HasComments: No