You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2024/05/08 11:40:17 UTC
[PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
weizhouapache opened a new pull request, #9059:
URL: https://github.com/apache/cloudstack/pull/9059
### Description
When reproduced the issue #8967, I got the following error
```
2024-05-03T14:24:16,885 WARN [c.c.n.IpAddressManagerImpl] (API-Job-Executor-44:[ctx-6da31d57, job-15369, ctx-eb716451]) (logid:d43b402b) Unable to revoke all the firewall rules for ip id=2 as a part of ip release
2024-05-03T14:24:29,282 DEBUG [c.c.n.IpAddressManagerImpl] (API-Job-Executor-44:[ctx-6da31d57, job-15369, ctx-eb716451]) (logid:d43b402b) Releasing ip id=2; sourceNat = false
2024-05-03T14:24:29,271 WARN [c.c.n.IpAddressManagerImpl] (API-Job-Executor-44:[ctx-6da31d57, job-15369, ctx-eb716451]) (logid:d43b402b) Failed to release resources for ip address id=2
2024-05-03T14:24:36,266 WARN [c.c.n.NetworkServiceImpl] (API-Job-Executor-44:[ctx-6da31d57, job-15369, ctx-eb716451]) (logid:d43b402b) Failed to release public ip address id=2
```
The errors are ignored, public IP is released successfully in cloudstack, but the IP is still associated to a VR. When associate the IP to another network, it caused an issue similar as #8967.
However, the reporter of #8967 could not find any error like "Failed to release" or "Unable to revoke" in their logs, so the root cause of #8967 could be different.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2185891183
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#discussion_r1593932547
##########
server/src/main/java/com/cloud/network/IpAddressManagerImpl.java:
##########
@@ -732,8 +732,9 @@ public boolean disassociatePublicIpAddress(long addrId, long userId, Account cal
PublicIpQuarantine publicIpQuarantine = null;
// Cleanup all ip address resources - PF/LB/Static nat rules
if (!cleanupIpResources(addrId, userId, caller)) {
- success = false;
- s_logger.warn("Failed to release resources for ip address id=" + addrId);
+ String msg = String.format("Failed to release resources for ip address id=%s", addrId);
+ s_logger.error(msg);
+ throw new CloudRuntimeException(msg);
Review Comment:
it does, but I think the process should be stopped here if the error happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2185909312
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2301531403
> @weizhouapache
>
> I am not able to reproduce the behaviour, do you have any other specific steps
>
> I have followed these steps
>
> Create 2 sessions and execute the following API at the same time
>
> 1. Execute disassociate IP address
> 2. Execute creates a firewall rule on the same IP
>
> Did not observe the log
>
> egrep 'Failed to release | Unable to revoke ' /var/log/cloudstack/management/management-server.log
>
>
> The create firewall API returns
> `Error: (HTTP 431, error code 4350) Unable to create firewall rule for the IP address ID=5 as IP is not associated with any network and no networkId is passed in`
>
> Also, I see the IPAddress present in the router even after the disassociate IP address is successfull
>
>
> cat /etc/cloudstack/ips.json
>
> ```
> }root@r-4-VM:~# cat /etc/cloudstack/ips.json
> {
> "eth0": [
> {
> "add": true,
> "broadcast": "10.1.1.255",
> "cidr": "10.1.1.1/24",
> "device": "eth0",
> "gateway": "",
> "netmask": "255.255.255.0",
> "network": "10.1.1.0/24",
> "nic_dev_id": "0",
> "nw_type": "guest",
> "one_to_one_nat": false,
> "public_ip": "10.1.1.1",
> "size": "24",
> "source_nat": false
> }
> ],
> "eth1": [
> {
> "add": true,
> "broadcast": "169.254.255.255",
> "cidr": "169.254.216.24/16",
> "device": "eth1",
> "gateway": "",
> "netmask": "255.255.0.0",
> "network": "169.254.0.0/16",
> "nic_dev_id": "1",
> "nw_type": "control",
> "one_to_one_nat": false,
> "public_ip": "169.254.216.24",
> "size": "16",
> "source_nat": false
> }
> ],
> "eth2": [
> {
> "add": true,
> "broadcast": "10.0.63.255",
> "cidr": "10.0.54.123/20",
> "device": "eth2",
> "first_i_p": true,
> "gateway": "10.0.48.1",
> "is_private_gateway": false,
> "mtu": "1500",
> "netmask": "255.255.240.0",
> "network": "10.0.48.0/20",
> "new_nic": false,
> "nic_dev_id": 2,
> "nw_type": "public",
> "one_to_one_nat": false,
> "public_ip": "10.0.54.123",
> "size": "20",
> "source_nat": true,
> "vif_mac_address": "1e:00:89:00:00:03"
> },
> {
> "add": false,
> "broadcast": "10.0.63.255",
> "cidr": "10.0.54.124/20",
> "device": "eth2",
> "first_i_p": false,
> "gateway": "10.0.48.1",
> "is_private_gateway": false,
> "mtu": "1500",
> "netmask": "255.255.240.0",
> "network": "10.0.48.0/20",
> "new_nic": false,
> "nic_dev_id": 2,
> "nw_type": "public",
> "one_to_one_nat": false,
> "public_ip": "10.0.54.124",
> "size": "20",
> "source_nat": false,
> "vif_mac_address": "1e:00:89:00:00:03"
> }
> ],
> "id": "ips"
> ```
@kiranchavala
Thanks
This might has been fixed by #9234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#discussion_r1650461762
##########
server/src/main/java/com/cloud/network/IpAddressManagerImpl.java:
##########
@@ -732,8 +732,9 @@ public boolean disassociatePublicIpAddress(long addrId, long userId, Account cal
PublicIpQuarantine publicIpQuarantine = null;
// Cleanup all ip address resources - PF/LB/Static nat rules
if (!cleanupIpResources(addrId, userId, caller)) {
- success = false;
- s_logger.warn("Failed to release resources for ip address id=" + addrId);
+ String msg = String.format("Failed to release resources for ip address id=%s", addrId);
+ s_logger.error(msg);
+ throw new CloudRuntimeException(msg);
Review Comment:
Hi @weizhouapache should these be addressed here, or later in separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2100759372
@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2100758299
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2101864590
<b>[SF] Trillian test result (tid-10194)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43853 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9059-t10194-kvm-centos7.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_events_resource | `Error` | 420.30 | test_events_resource.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2100387266
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2100512158
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache closed pull request #9059: server: throw exception if fail to cleanup IP resources when release a public IP
URL: https://github.com/apache/cloudstack/pull/9059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#discussion_r1650477434
##########
server/src/main/java/com/cloud/network/IpAddressManagerImpl.java:
##########
@@ -732,8 +732,9 @@ public boolean disassociatePublicIpAddress(long addrId, long userId, Account cal
PublicIpQuarantine publicIpQuarantine = null;
// Cleanup all ip address resources - PF/LB/Static nat rules
if (!cleanupIpResources(addrId, userId, caller)) {
- success = false;
- s_logger.warn("Failed to release resources for ip address id=" + addrId);
+ String msg = String.format("Failed to release resources for ip address id=%s", addrId);
+ s_logger.error(msg);
+ throw new CloudRuntimeException(msg);
Review Comment:
@sureshanaparti @DaanHoogland
renamed the last method from `markAsUnavailable` to `markAsReleasing`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2185790993
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2301521094
@weizhouapache
I am not able to reproduce the behaviour, do you have any other specific steps
I have followed these steps
Create 2 sessions and execute the following API at the same time
1. Execute disassociate IP address
2. Execute creates a firewall rule on the same IP
Did not observe the log
egrep 'Failed to release | Unable to revoke ' /var/log/cloudstack/management/management-server.log
The create firewall API returns
`Error: (HTTP 431, error code 4350) Unable to create firewall rule for the IP address ID=5 as IP is not associated with any network and no networkId is passed in`
Also, I see the IPAddress present in the router even after the disassociate IP address is successfull
cat /etc/cloudstack/ips.json
```
}root@r-4-VM:~# cat /etc/cloudstack/ips.json
{
"eth0": [
{
"add": true,
"broadcast": "10.1.1.255",
"cidr": "10.1.1.1/24",
"device": "eth0",
"gateway": "",
"netmask": "255.255.255.0",
"network": "10.1.1.0/24",
"nic_dev_id": "0",
"nw_type": "guest",
"one_to_one_nat": false,
"public_ip": "10.1.1.1",
"size": "24",
"source_nat": false
}
],
"eth1": [
{
"add": true,
"broadcast": "169.254.255.255",
"cidr": "169.254.216.24/16",
"device": "eth1",
"gateway": "",
"netmask": "255.255.0.0",
"network": "169.254.0.0/16",
"nic_dev_id": "1",
"nw_type": "control",
"one_to_one_nat": false,
"public_ip": "169.254.216.24",
"size": "16",
"source_nat": false
}
],
"eth2": [
{
"add": true,
"broadcast": "10.0.63.255",
"cidr": "10.0.54.123/20",
"device": "eth2",
"first_i_p": true,
"gateway": "10.0.48.1",
"is_private_gateway": false,
"mtu": "1500",
"netmask": "255.255.240.0",
"network": "10.0.48.0/20",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.0.54.123",
"size": "20",
"source_nat": true,
"vif_mac_address": "1e:00:89:00:00:03"
},
{
"add": false,
"broadcast": "10.0.63.255",
"cidr": "10.0.54.124/20",
"device": "eth2",
"first_i_p": false,
"gateway": "10.0.48.1",
"is_private_gateway": false,
"mtu": "1500",
"netmask": "255.255.240.0",
"network": "10.0.48.0/20",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.0.54.124",
"size": "20",
"source_nat": false,
"vif_mac_address": "1e:00:89:00:00:03"
}
],
"id": "ips"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#discussion_r1593916362
##########
server/src/main/java/com/cloud/network/IpAddressManagerImpl.java:
##########
@@ -732,8 +732,9 @@ public boolean disassociatePublicIpAddress(long addrId, long userId, Account cal
PublicIpQuarantine publicIpQuarantine = null;
// Cleanup all ip address resources - PF/LB/Static nat rules
if (!cleanupIpResources(addrId, userId, caller)) {
- success = false;
- s_logger.warn("Failed to release resources for ip address id=" + addrId);
+ String msg = String.format("Failed to release resources for ip address id=%s", addrId);
+ s_logger.error(msg);
+ throw new CloudRuntimeException(msg);
Review Comment:
does this block any other subsequent calls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2100400045
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9059?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.31%. Comparing base [(`ea9a0f4`)](https://app.codecov.io/gh/apache/cloudstack/commit/ea9a0f4adf81b92abd7eddc4a6be57a131ef001b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4f0b26b`)](https://app.codecov.io/gh/apache/cloudstack/pull/9059?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.19 #9059 +/- ##
============================================
- Coverage 14.96% 4.31% -10.65%
============================================
Files 5373 363 -5010
Lines 469024 29180 -439844
Branches 58818 5091 -53727
============================================
- Hits 70197 1260 -68937
+ Misses 391056 27778 -363278
+ Partials 7771 142 -7629
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9059/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9059/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.31% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9059/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9059?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2100385066
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2101904179
<b>[SF] Trillian test result (tid-10192)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47085 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9059-t10192-xenserver-71.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_events_resource | `Error` | 336.85 | test_events_resource.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2101958885
<b>[SF] Trillian test result (tid-10193)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 50852 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9059-t10193-vmware-67u3.zip
Smoke tests completed. 128 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_events_resource | `Error` | 351.57 | test_events_resource.py
test_create_pvlan_network | `Error` | 0.09 | test_pvlan.py
test_02_trigger_shutdown | `Failure` | 341.73 | test_safe_shutdown.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#discussion_r1593916362
##########
server/src/main/java/com/cloud/network/IpAddressManagerImpl.java:
##########
@@ -732,8 +732,9 @@ public boolean disassociatePublicIpAddress(long addrId, long userId, Account cal
PublicIpQuarantine publicIpQuarantine = null;
// Cleanup all ip address resources - PF/LB/Static nat rules
if (!cleanupIpResources(addrId, userId, caller)) {
- success = false;
- s_logger.warn("Failed to release resources for ip address id=" + addrId);
+ String msg = String.format("Failed to release resources for ip address id=%s", addrId);
+ s_logger.error(msg);
+ throw new CloudRuntimeException(msg);
Review Comment:
does this block any other subsequent calls, & changes behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2301532093
Closing
Reopen if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2185775170
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2185772740
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: throw exception if fail to cleanup IP resources when release a public IP [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#issuecomment-2185791390
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org