You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/04 13:34:49 UTC

[GitHub] [skywalking-data-collect-protocol] arugal commented on a change in pull request #18: Enhancement browser protocol

arugal commented on a change in pull request #18: Enhancement browser protocol
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r374671974
 
 

 ##########
 File path: browser/BrowserPerf.proto
 ##########
 @@ -25,36 +25,56 @@ import "common/common.proto";
 
 // Collect performance raw data from browser.
 service BrowserPerfService {
-    rpc collect (stream BrowserPerfData) returns (Commands) {
+
+    // report once per page
+    rpc collectPerfData (stream BrowserPerfData) returns (Commands) {
 
 Review comment:
   removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services