You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/02/19 21:35:48 UTC
Review Request: SQOOP-444: Support incremental import for free form queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/
-----------------------------------------------------------
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Summary
-------
I've incorporated support for incremental import of free form queries to sqoop.
This addresses bug SQOOP-444.
https://issues.apache.org/jira/browse/SQOOP-444
Diffs
-----
/src/java/org/apache/sqoop/tool/ImportTool.java 1245157
/src/test/com/cloudera/sqoop/TestIncrementalImport.java 1245157
Diff: https://reviews.apache.org/r/3961/diff
Testing
-------
ant -Dhadoopversion={20,23,100} test
live testing on CDH3 and Microsoft SQL Server
Thanks,
Jarek
Re: Review Request: SQOOP-444: Support incremental import for free form
queries
Posted by Jarek Cecho <ja...@apache.org>.
> On 2012-02-28 19:39:11, Bilung Lee wrote:
> > Looks good to me.
Updated patch is already attached to JIRA, please feel free to commit.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5404
-----------------------------------------------------------
On 2012-02-28 14:43:52, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3961/
> -----------------------------------------------------------
>
> (Updated 2012-02-28 14:43:52)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've incorporated support for incremental import of free form queries to sqoop.
>
>
> This addresses bug SQOOP-444.
> https://issues.apache.org/jira/browse/SQOOP-444
>
>
> Diffs
> -----
>
> /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1294667
> /src/java/org/apache/sqoop/tool/ImportTool.java 1294667
>
> Diff: https://reviews.apache.org/r/3961/diff
>
>
> Testing
> -------
>
> ant -Dhadoopversion={20,23,100} test
> live testing on CDH3 and Microsoft SQL Server
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-444: Support incremental import for free form
queries
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5404
-----------------------------------------------------------
Ship it!
Looks good to me.
- Bilung
On 2012-02-28 14:43:52, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3961/
> -----------------------------------------------------------
>
> (Updated 2012-02-28 14:43:52)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've incorporated support for incremental import of free form queries to sqoop.
>
>
> This addresses bug SQOOP-444.
> https://issues.apache.org/jira/browse/SQOOP-444
>
>
> Diffs
> -----
>
> /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1294667
> /src/java/org/apache/sqoop/tool/ImportTool.java 1294667
>
> Diff: https://reviews.apache.org/r/3961/diff
>
>
> Testing
> -------
>
> ant -Dhadoopversion={20,23,100} test
> live testing on CDH3 and Microsoft SQL Server
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-444: Support incremental import for free form
queries
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/
-----------------------------------------------------------
(Updated 2012-02-28 14:43:52.891865)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Changes
-------
I've applied both suggestions and try it again in live testing environment against Microsoft SQL Server and MySQL.
Summary
-------
I've incorporated support for incremental import of free form queries to sqoop.
This addresses bug SQOOP-444.
https://issues.apache.org/jira/browse/SQOOP-444
Diffs (updated)
-----
/src/test/com/cloudera/sqoop/TestIncrementalImport.java 1294667
/src/java/org/apache/sqoop/tool/ImportTool.java 1294667
Diff: https://reviews.apache.org/r/3961/diff
Testing
-------
ant -Dhadoopversion={20,23,100} test
live testing on CDH3 and Microsoft SQL Server
Thanks,
Jarek
Re: Review Request: SQOOP-444: Support incremental import for free form
queries
Posted by Jarek Cecho <ja...@apache.org>.
> On 2012-02-27 20:02:04, Bilung Lee wrote:
> > /src/java/org/apache/sqoop/tool/ImportTool.java, line 183
> > <https://reviews.apache.org/r/3961/diff/1/?file=75912#file75912line183>
> >
> > This syntax ("AS alias") doesn't seem to work with Oracle. You may want to try dropping the "AS" keyword, which seems to be accepted by most major databases.
Thank you for checking against Oracle sir, I do not have that option at the moment.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5344
-----------------------------------------------------------
On 2012-02-28 14:43:52, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3961/
> -----------------------------------------------------------
>
> (Updated 2012-02-28 14:43:52)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've incorporated support for incremental import of free form queries to sqoop.
>
>
> This addresses bug SQOOP-444.
> https://issues.apache.org/jira/browse/SQOOP-444
>
>
> Diffs
> -----
>
> /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1294667
> /src/java/org/apache/sqoop/tool/ImportTool.java 1294667
>
> Diff: https://reviews.apache.org/r/3961/diff
>
>
> Testing
> -------
>
> ant -Dhadoopversion={20,23,100} test
> live testing on CDH3 and Microsoft SQL Server
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-444: Support incremental import for free form
queries
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5344
-----------------------------------------------------------
Thanks for the patch! Two comments below.
/src/java/org/apache/sqoop/tool/ImportTool.java
<https://reviews.apache.org/r/3961/#comment11659>
This syntax ("AS alias") doesn't seem to work with Oracle. You may want to try dropping the "AS" keyword, which seems to be accepted by most major databases.
/src/java/org/apache/sqoop/tool/ImportTool.java
<https://reviews.apache.org/r/3961/#comment11648>
This replacement is specific to free form query? If so, better move this to the else block above.
- Bilung
On 2012-02-19 20:35:48, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3961/
> -----------------------------------------------------------
>
> (Updated 2012-02-19 20:35:48)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've incorporated support for incremental import of free form queries to sqoop.
>
>
> This addresses bug SQOOP-444.
> https://issues.apache.org/jira/browse/SQOOP-444
>
>
> Diffs
> -----
>
> /src/java/org/apache/sqoop/tool/ImportTool.java 1245157
> /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1245157
>
> Diff: https://reviews.apache.org/r/3961/diff
>
>
> Testing
> -------
>
> ant -Dhadoopversion={20,23,100} test
> live testing on CDH3 and Microsoft SQL Server
>
>
> Thanks,
>
> Jarek
>
>