[jira] [Commented] (CALCITE-2140) Basic implementation of Statement#getMoreResults()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379610#comment-16379610 ] 

ASF GitHub Bot commented on CALCITE-2140:
-----------------------------------------

GitHub user laurentgo opened a pull request:

    https://github.com/apache/calcite-avatica/pull/24

    [CALCITE-2140] Basic implementation of Statement#getMoreResults()

    Add a basic implementation of Statement#getMoreResults() and
    Statement#getMoreResults(int), only supporting CLOSE_CURRENT_RESULT.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/calcite-avatica laurentgo/CALCITE-2140

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/calcite-avatica/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 09700bf3cc7505edcde6507831c38fc0622b41f0
Author: Laurent Goujon <la...@...>
Date:   2018-02-28T01:08:36Z

    [CALCITE-2140] Basic implementation of Statement#getMoreResults()
    
    Add a basic implementation of Statement#getMoreResults() and
    Statement#getMoreResults(int), only supporting CLOSE_CURRENT_RESULT.

----


> Basic implementation of Statement#getMoreResults()
> --------------------------------------------------
>
>                 Key: CALCITE-2140
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2140
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Laurent Goujon
>            Priority: Minor
>
> Methods {{Statement#getMoreResults}} and {{Statement#getMoreResults(int)}} are currently throwing a {{SQLFeatureNotSupportedException}}, but at least one tool (DataGrip) is calling the first method after each SQL request.
> Avatica doesn't support multiple {{ResultSet}} for a given {{Statement}} (see [https://github.com/apache/calcite-avatica/blob/master/core/src/main/java/org/apache/calcite/avatica/AvaticaDatabaseMetaData.java#L1148]), so a basic implementation could close the current open result set (if any), and return {{false}} for both methods (unless the int argument is equal to {{Statement.KEEP_CURRENT_RESULT}} or {{Statement.CLOSE_ALL_RESULTS}}).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)