You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/21 14:36:43 UTC
[GitHub] [beam] kamilwu opened a new pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
kamilwu opened a new pull request #11776:
URL: https://github.com/apache/beam/pull/11776
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-635908932
@lakshmanok Do you mean the response object returned from the API? If so, tt would look like this:
```
sentences {
text {
content: "My experience so far has been fantastic!"
}
sentiment {
magnitude: 0.8999999761581421
score: 0.8999999761581421
}
}
sentences {
text {
content: "I\'d really recommend this product."
begin_offset: 41
}
sentiment {
magnitude: 0.8999999761581421
score: 0.8999999761581421
}
}
...many lines omitted
document_sentiment {
magnitude: 1.899999976158142
score: 0.8999999761581421
}
```
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-636682308
Thanks everyone! Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu edited a comment on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu edited a comment on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-635908932
@lakshmanok Do you mean the response object returned from the API? If so, it would look like this:
```
sentences {
text {
content: "My experience so far has been fantastic!"
}
sentiment {
magnitude: 0.8999999761581421
score: 0.8999999761581421
}
}
sentences {
text {
content: "I\'d really recommend this product."
begin_offset: 41
}
sentiment {
magnitude: 0.8999999761581421
score: 0.8999999761581421
}
}
...many lines omitted
document_sentiment {
magnitude: 1.899999976158142
score: 0.8999999761581421
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-636067245
I have added that. Please take a look, the link is the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-635467347
The path is: https://apache-beam-website-pull-requests.storage.googleapis.com/11776/documentation/patterns/ai-platform/index.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-634716326
Run Portable_Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on a change in pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
aaltay commented on a change in pull request #11776:
URL: https://github.com/apache/beam/pull/11776#discussion_r430863465
##########
File path: sdks/python/apache_beam/examples/snippets/snippets.py
##########
@@ -1520,3 +1528,90 @@ def bigqueryio_deadletter():
# [END BigQueryIODeadLetter]
return result
+
+
+def extract_sentiments(response):
+ # [START nlp_extract_sentiments]
+ return {
+ 'sentences': [{
+ sentence.text.content: sentence.sentiment.score
+ } for sentence in response.sentences],
+ 'document_sentiment': response.document_sentiment.score,
+ }
+
Review comment:
Could you remove trailing empty lines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] datancoffee commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
datancoffee commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-635470445
Looks very good, thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu merged pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu merged pull request #11776:
URL: https://github.com/apache/beam/pull/11776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #11776:
URL: https://github.com/apache/beam/pull/11776#discussion_r431191464
##########
File path: sdks/python/apache_beam/examples/snippets/snippets.py
##########
@@ -1520,3 +1528,90 @@ def bigqueryio_deadletter():
# [END BigQueryIODeadLetter]
return result
+
+
+def extract_sentiments(response):
+ # [START nlp_extract_sentiments]
+ return {
+ 'sentences': [{
+ sentence.text.content: sentence.sentiment.score
+ } for sentence in response.sentences],
+ 'document_sentiment': response.document_sentiment.score,
+ }
+
Review comment:
Done, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-636098800
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-632724995
R: @aaltay Could you take a look?
Website staging is not working at the moment, fix is in progress: https://github.com/apache/beam/pull/11796
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] datancoffee commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
datancoffee commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-635464055
> > Staged: https://apache-beam-website-pull-requests.storage.googleapis.com/11776/index.html
>
> LGTM. Maybe give @lakshmanok @datancoffee another day to review but after that feel free to merge.
Sorry, what's the path to the actual preview page?
This link leads me to main page https://apache-beam-website-pull-requests.storage.googleapis.com/11776/index.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-635461000
> Staged: https://apache-beam-website-pull-requests.storage.googleapis.com/11776/index.html
LGTM. Maybe give @lakshmanok @datancoffee another day to review but after that feel free to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lakshmanok commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
lakshmanok commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-636037842
Kamil, Yes, exactly.
On Fri, May 29, 2020, 3:53 AM Kamil Wasilewski <no...@github.com>
wrote:
> @lakshmanok <https://github.com/lakshmanok> Do you mean the response
> object returned from the API? If so, tt would look like this:
>
> sentences {
> text {
> content: "My experience so far has been fantastic!"
> }
> sentiment {
> magnitude: 0.8999999761581421
> score: 0.8999999761581421
> }
> }
> sentences {
> text {
> content: "I\'d really recommend this product."
> begin_offset: 41
> }
> sentiment {
> magnitude: 0.8999999761581421
> score: 0.8999999761581421
> }
> }
>
> ...many lines omitted
>
> document_sentiment {
> magnitude: 1.899999976158142
> score: 0.8999999761581421
> }
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/11776#issuecomment-635908932>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AANJPZ667ZJNZM5L3XWECE3RT6H37ANCNFSM4NG4NBCQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lakshmanok commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
lakshmanok commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-635479853
looks great. In the "extracting sentiments" section, would it be possible
to show part of the input JSON, so that it is clearer what the access
pattern is?
Then, explicitly recommend that the developer look at entities.txt or
sentiments.txt to see how to extract other kinds of data.
On Thu, May 28, 2020 at 9:58 AM Sergei Sokolenko <no...@github.com>
wrote:
> Looks very good, thank you!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/11776#issuecomment-635470445>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AANJPZ7ZNUVYFCO7IQIQOFTRT2J2BANCNFSM4NG4NBCQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu edited a comment on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
kamilwu edited a comment on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-635908932
@lakshmanok Do you mean the response object returned from the API? If so, tt would look like this:
```
sentences {
text {
content: "My experience so far has been fantastic!"
}
sentiment {
magnitude: 0.8999999761581421
score: 0.8999999761581421
}
}
sentences {
text {
content: "I\'d really recommend this product."
begin_offset: 41
}
sentiment {
magnitude: 0.8999999761581421
score: 0.8999999761581421
}
}
...many lines omitted
document_sentiment {
magnitude: 1.899999976158142
score: 0.8999999761581421
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lakshmanok commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform
Posted by GitBox <gi...@apache.org>.
lakshmanok commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-636097747
looks good, thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org