You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/08 11:09:06 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #289: Add csv mode to datafusion cli

Dandandan commented on a change in pull request #289:
URL: https://github.com/apache/arrow-datafusion/pull/289#discussion_r628737157



##########
File path: datafusion-cli/src/main.rs
##########
@@ -51,6 +56,20 @@ pub async fn main() {
                 .validator(is_valid_batch_size)
                 .takes_value(true),
         )
+        .arg(
+            Arg::with_name("file")
+                .help("Execute commands from file, then exit")
+                .short("f")
+                .long("file")
+                .validator(is_valid_file)
+                .takes_value(true),
+        )
+        .arg(

Review comment:
       I would think at this moment we don't need to be compatible with `psql` per se regarding the command line arguments. So `--format=csv` would be a bit more user friendly I would say




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org