You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by va...@apache.org on 2023/04/26 20:09:26 UTC
[couchdb] 01/01: Noticed the new internal error couchjs test was flaky
This is an automated email from the ASF dual-hosted git repository.
vatamane pushed a commit to branch unflake-couchjs-internal-test
in repository https://gitbox.apache.org/repos/asf/couchdb.git
commit 323fb54e8d70d4d6ebe22255f0da8c974277b226
Author: Nick Vatamaniuc <va...@gmail.com>
AuthorDate: Wed Apr 26 16:08:19 2023 -0400
Noticed the new internal error couchjs test was flaky
It's designed to crash and exit but depending when it does it exactly it may
generate different errors. Add a few more clauses. Hopefully we don't have to
completely remove it or comment it out.
---
src/couch/test/eunit/couch_js_tests.erl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/couch/test/eunit/couch_js_tests.erl b/src/couch/test/eunit/couch_js_tests.erl
index afd42bb72..09cab59a5 100644
--- a/src/couch/test/eunit/couch_js_tests.erl
+++ b/src/couch/test/eunit/couch_js_tests.erl
@@ -265,6 +265,12 @@ should_exit_on_internal_error() ->
% emits an error log before dying
throw:{<<"InternalError">>, _} ->
ok;
+ % gen_server may die before replying
+ exit:{noproc, {gen_server,call, _}} ->
+ ok;
+ % or it may die with an epipe if it crashes while we send/recv data to it
+ exit:{epipe, {gen_server, call, _}} ->
+ ok;
% It may fail and just exit the process. That's expected as well
throw:{os_process_error, _} ->
ok