[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4139: [Feature-4138][Master] dispatch workgroup error add sleep time

[GitBox <gi...@apache.org>]

lenboo commented on a change in pull request #4139:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4139#discussion_r539097235



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumer.java
##########
@@ -139,7 +140,13 @@ public void run() {
                 for (String dispatchFailedTask : failedDispatchTasks) {
                     taskPriorityQueue.put(dispatchFailedTask);
                 }
+                // If there are tasks in a cycle that cannot find the worker group,
+                // sleep for 1 second
+                if (!failedDispatchTasks.isEmpty()  && taskPriorityQueue.size() <= fetchTaskNum) {

Review comment:
        "taskPriorityQueue.size() <= failedDispatchTasks.size()" is more better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org