You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2019/02/22 08:20:00 UTC

[jira] [Comment Edited] (OAK-8071) Logging to detect commits carrying over from previous GC generation can block other threads from committing

    [ https://issues.apache.org/jira/browse/OAK-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774894#comment-16774894 ] 

Michael Dürig edited comment on OAK-8071 at 2/22/19 8:19 AM:
-------------------------------------------------------------

Just noted that this change causes a performance regression in our benchmarks:
{noformat}
Apache Jackrabbit Oak
# FlatTreeUpdateTest               C     min     10%     50%     90%     max       N
Oak-Segment-Tar (base)             1    5593    5600    5938    6302    6321      11
Oak-Segment-Tar (OAK-8071)         1    6849    6849    7076    8821    8821       9
{noformat}
 


was (Author: mduerig):
Just noted though that removing this check causes a lot of additional commits to end up on the {{CommitsTracker#commits}} queue. This causes a performance regression in our benchmarks:
{noformat}
Apache Jackrabbit Oak
# FlatTreeUpdateTest               C     min     10%     50%     90%     max       N
Oak-Segment-Tar (base)             1    5593    5600    5938    6302    6321      11
Oak-Segment-Tar (OAK-8071)         1    6849    6849    7076    8821    8821       9
{noformat}
Will have to look for another solution.

> Logging to detect commits carrying over from previous GC generation can block other threads from committing
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-8071
>                 URL: https://issues.apache.org/jira/browse/OAK-8071
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Blocker
>             Fix For: 1.12, 1.11.0, 1.10.1, 1.8.12
>
>
> Add logging / monitoring to detect the situation from OAK-8014.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)