You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/01/23 10:27:38 UTC

[GitHub] [pulsar] ivankelly commented on a change in pull request #6129: [CPP] Compile fixes for ARM cpus

ivankelly commented on a change in pull request #6129: [CPP] Compile fixes for ARM cpus
URL: https://github.com/apache/pulsar/pull/6129#discussion_r370038664
 
 

 ##########
 File path: pulsar-client-cpp/perf/RateLimiter.h
 ##########
 @@ -50,7 +50,7 @@ RateLimiter::RateLimiter(double rate)
         : interval_(std::chrono::microseconds((long)(1e6 / rate))),
           storedPermits_(0.0),
           maxPermits_(rate),
-          nextFree_() {
 
 Review comment:
   These last two changes look completely unrelated. Add something to the commit message to at least explain them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services