You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/20 07:54:10 UTC
[GitHub] [doris] BePPPower opened a new pull request, #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values
BePPPower opened a new pull request, #16117:
URL: https://github.com/apache/doris/pull/16117
# Proposed changes
Issue Number: close #xxx
This pr fix two bugs:
1. _jdbc_scanner may be nullptr in vjdbc_connector.cpp, so we use another method to count jdbc statistic.
2. In the batch insertion scenario, oracle database does not support syntax `insert into tables values (...),(...);` , what it supports is:
```sql
insert all
into table(col1,col2) values(c1v1, c2v1)
into table(col1,col2) values(c1v2, c2v2)
SELECT 1 FROM DUAL;
```
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #16117:
URL: https://github.com/apache/doris/pull/16117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16117:
URL: https://github.com/apache/doris/pull/16117#issuecomment-1398078937
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.4 seconds
load time: 489 seconds
storage size: 17122783156 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230120084641_clickbench_pr_84608.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16117:
URL: https://github.com/apache/doris/pull/16117#issuecomment-1398164831
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BePPPower commented on a diff in pull request #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values
Posted by GitBox <gi...@apache.org>.
BePPPower commented on code in PR #16117:
URL: https://github.com/apache/doris/pull/16117#discussion_r1082310938
##########
be/src/vec/exec/scan/new_jdbc_scanner.cpp:
##########
@@ -163,6 +164,13 @@ Status NewJdbcScanner::_get_block_impl(RuntimeState* state, Block* block, bool*
Status NewJdbcScanner::close(RuntimeState* state) {
RETURN_IF_ERROR(VScanner::close(state));
RETURN_IF_ERROR(_jdbc_connector->close());
+ JdbcConnector::JdbcStatistic& jdbc_statistic = _jdbc_connector->get_jdbc_statistic();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16117:
URL: https://github.com/apache/doris/pull/16117#issuecomment-1398033393
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #16117:
URL: https://github.com/apache/doris/pull/16117#discussion_r1082297783
##########
be/src/vec/exec/scan/new_jdbc_scanner.cpp:
##########
@@ -163,6 +164,13 @@ Status NewJdbcScanner::_get_block_impl(RuntimeState* state, Block* block, bool*
Status NewJdbcScanner::close(RuntimeState* state) {
RETURN_IF_ERROR(VScanner::close(state));
RETURN_IF_ERROR(_jdbc_connector->close());
+ JdbcConnector::JdbcStatistic& jdbc_statistic = _jdbc_connector->get_jdbc_statistic();
Review Comment:
Better not update counter when close().
Because close() may be called after query is done, so FE will not receive these metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16117:
URL: https://github.com/apache/doris/pull/16117#issuecomment-1398237079
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16117:
URL: https://github.com/apache/doris/pull/16117#issuecomment-1398237133
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org