You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/03/17 07:10:03 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #738: [MINOR] test: fix CoordinatorGrpcTest#shuffleServerHeartbeatTest on Linux SSD platform
kaijchen opened a new pull request, #738:
URL: https://github.com/apache/incubator-uniffle/pull/738
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Fix CoordinatorGrpcTest#shuffleServerHeartbeatTest on Linux SSD platform
### Why are the changes needed?
```
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] CoordinatorGrpcTest.shuffleServerHeartbeatTest:240 expected: <HDD> but was: <SSD>
[ERROR] Errors:
[ERROR] CoordinatorGrpcTest.getShuffleAssignmentsTest:125 » Runtime No shuffle server ...
[ERROR] CoordinatorGrpcTest.rpcMetricsTest:274 » Runtime No shuffle server connected
[INFO]
[ERROR] Tests run: 6, Failures: 1, Errors: 2, Skipped: 0
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
[INFO] Running org.apache.uniffle.test.CoordinatorGrpcTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.622 s - in org.apache.uniffle.test.CoordinatorGrpcTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
[INFO]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen merged pull request #738: [MINOR] test: fix CoordinatorGrpcTest#shuffleServerHeartbeatTest on Linux SSD platform
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen merged PR #738:
URL: https://github.com/apache/incubator-uniffle/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #738: [MINOR] test: fix CoordinatorGrpcTest#shuffleServerHeartbeatTest on Linux SSD platform
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #738:
URL: https://github.com/apache/incubator-uniffle/pull/738#issuecomment-1473284296
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#738](https://codecov.io/gh/apache/incubator-uniffle/pull/738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dcfe1c) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/d3981485daf97869337c95783fa842cac8af1a76?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d398148) will **increase** coverage by `1.10%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #738 +/- ##
============================================
+ Coverage 60.73% 61.84% +1.10%
+ Complexity 1859 1763 -96
============================================
Files 231 207 -24
Lines 12861 10312 -2549
Branches 1073 1030 -43
============================================
- Hits 7811 6377 -1434
+ Misses 4635 3594 -1041
+ Partials 415 341 -74
```
[see 26 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/738/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org