You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/09 08:53:59 UTC

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1444: chore: added global test data file

juzhiyuan commented on a change in pull request #1444:
URL: https://github.com/apache/apisix-dashboard/pull/1444#discussion_r572698750



##########
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##########
@@ -90,15 +87,18 @@ context('Create Route with Upstream', () => {
     cy.contains('Next').click();
     cy.contains('Next').click();
     cy.contains('Submit').click();
-    cy.contains(data.submitSuccess).should('be.visible');
+    cy.contains(this.data.submitSuccess).should('be.visible');
     cy.contains('Goto List').click();
     cy.url().should('contains', 'routes/list');
 
     // check if the changes have been saved
     cy.get(this.domSelector.nameSelector).type(this.data.routeName);
     cy.contains('Search').click();
+
     cy.contains(this.data.routeName).siblings().contains('Edit').click();
-    cy.contains('Next').click();
+    // ensure it has already change to edit page

Review comment:
       https://www.grammarly.com/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org