You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/01/26 15:10:00 UTC
[GitHub] [httpcomponents-core] arturobernalg opened a new pull request #249: HTTPCORE-662 - add http status code 418
arturobernalg opened a new pull request #249:
URL: https://github.com/apache/httpcomponents-core/pull/249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg closed pull request #249: HTTPCORE-662 - add http status code 418
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #249:
URL: https://github.com/apache/httpcomponents-core/pull/249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] thc202 commented on a change in pull request #249: HTTPCORE-662 - add http status code 418
Posted by GitBox <gi...@apache.org>.
thc202 commented on a change in pull request #249:
URL: https://github.com/apache/httpcomponents-core/pull/249#discussion_r564603108
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java
##########
@@ -158,6 +159,8 @@ private HttpStatus() {
public static final int SC_REQUESTED_RANGE_NOT_SATISFIABLE = 416;
/** {@code 417 Expectation Failed} (HTTP/1.1 - RFC 7231) */
public static final int SC_EXPECTATION_FAILED = 417;
+ /** {@code 418 I'm a teapot Failed} (HTTP/1.0 - RFC 2324) */
+ public static final int SC_I_AM_A_TEAPOT_FAILED = 418;
Review comment:
Was "Failed" added on purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on pull request #249: HTTPCORE-662 - add http status code 418
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #249:
URL: https://github.com/apache/httpcomponents-core/pull/249#issuecomment-767759417
> RFC 2324
Hi @ok2c
at the time it seemed the correct option. Maybe i was wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #249: HTTPCORE-662 - add http status code 418
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #249:
URL: https://github.com/apache/httpcomponents-core/pull/249#issuecomment-767756565
@arturobernalg Is RFC 2324 for real? Why do we need to support it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #249: HTTPCORE-662 - add http status code 418
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #249:
URL: https://github.com/apache/httpcomponents-core/pull/249#discussion_r564689398
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java
##########
@@ -158,6 +159,8 @@ private HttpStatus() {
public static final int SC_REQUESTED_RANGE_NOT_SATISFIABLE = 416;
/** {@code 417 Expectation Failed} (HTTP/1.1 - RFC 7231) */
public static final int SC_EXPECTATION_FAILED = 417;
+ /** {@code 418 I'm a teapot Failed} (HTTP/1.0 - RFC 2324) */
+ public static final int SC_I_AM_A_TEAPOT_FAILED = 418;
Review comment:
Nop. Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org