You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Nithya Janarthanan (Code Review)" <ge...@cloudera.org> on 2018/04/17 21:43:59 UTC
[Impala-ASF-CR] Add new queries to targeted-perf workload
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9979
Change subject: Add new queries to targeted-perf workload
......................................................................
Add new queries to targeted-perf workload
Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
---
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_1.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_2.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_3.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_4.test
A testdata/workloads/targeted-perf/queries/primitive_count_star.test
A testdata/workloads/targeted-perf/queries/primitive_decimal_arithmetic.test
A testdata/workloads/targeted-perf/queries/primitive_filter_bigint_in_list.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_appx_median.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_to_date.test
M testdata/workloads/targeted-perf/queries/primitive_long_predicate.test
A testdata/workloads/targeted-perf/queries/primitive_many_fragments.test
A testdata/workloads/targeted-perf/queries/primitive_many_independent_fragments.test
A testdata/workloads/targeted-perf/queries/primitive_orderby_bigint_expression.test
A testdata/workloads/targeted-perf/queries/primitive_shuffle_1mb_rows.test
14 files changed, 675 insertions(+), 171 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9979/3
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 3
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: IMPALA-6819: Add new queries to targeted-perf workload
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2417/
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 May 2018 16:27:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: IMPALA-6819: Add new queries to targeted-perf workload
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 May 2018 17:43:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: IMPALA-6819: Add new queries to targeted-perf workload
......................................................................
IMPALA-6819: Add new queries to targeted-perf workload
Description:
Adding new queries to the targeted-perf workload that is
used by Impala performance tests run via $IMPALA_HOME/bin/run-workload.py
Testing:
Ran the performance tests for the targeted-perf workload
and all the tests passed
Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Reviewed-on: http://gerrit.cloudera.org:8080/9979
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: David Knupp <dk...@cloudera.com>
---
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_1.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_2.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_3.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_4.test
A testdata/workloads/targeted-perf/queries/primitive_count_star.test
A testdata/workloads/targeted-perf/queries/primitive_decimal_arithmetic.test
A testdata/workloads/targeted-perf/queries/primitive_filter_bigint_in_list.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_appx_median.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_to_date.test
M testdata/workloads/targeted-perf/queries/primitive_long_predicate.test
A testdata/workloads/targeted-perf/queries/primitive_many_fragments.test
A testdata/workloads/targeted-perf/queries/primitive_many_independent_fragments.test
A testdata/workloads/targeted-perf/queries/primitive_orderby_bigint_expression.test
A testdata/workloads/targeted-perf/queries/primitive_shuffle_1mb_rows.test
14 files changed, 675 insertions(+), 171 deletions(-)
Approvals:
Impala Public Jenkins: Verified
David Knupp: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 6
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: IMPALA-6819: Add new queries to targeted-perf workload
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2413/
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 May 2018 05:09:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload
Posted by "Nithya Janarthanan (Code Review)" <ge...@cloudera.org>.
Nithya Janarthanan has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9979 )
Change subject: IMPALA-6819: Add new queries to targeted-perf workload
......................................................................
IMPALA-6819: Add new queries to targeted-perf workload
Description:
Adding new queries to the targeted-perf workload that is
used by Impala performance tests run via $IMPALA_HOME/bin/run-workload.py
Testing:
Ran the performance tests for the targeted-perf workload
and all the tests passed
Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
---
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_1.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_2.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_3.test
A testdata/workloads/targeted-perf/queries/primitive_conjunct_ordering_4.test
A testdata/workloads/targeted-perf/queries/primitive_count_star.test
A testdata/workloads/targeted-perf/queries/primitive_decimal_arithmetic.test
A testdata/workloads/targeted-perf/queries/primitive_filter_bigint_in_list.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_appx_median.test
A testdata/workloads/targeted-perf/queries/primitive_intrinsic_to_date.test
M testdata/workloads/targeted-perf/queries/primitive_long_predicate.test
A testdata/workloads/targeted-perf/queries/primitive_many_fragments.test
A testdata/workloads/targeted-perf/queries/primitive_many_independent_fragments.test
A testdata/workloads/targeted-perf/queries/primitive_orderby_bigint_expression.test
A testdata/workloads/targeted-perf/queries/primitive_shuffle_1mb_rows.test
14 files changed, 675 insertions(+), 171 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9979/4
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
[Impala-ASF-CR] Add new queries to targeted-perf workload
Posted by "Mostafa Mokhtar (Code Review)" <ge...@cloudera.org>.
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: Add new queries to targeted-perf workload
......................................................................
Patch Set 3:
Please add a description to the change describing the high level goals behind the queries.
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 3
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 00:55:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add new queries to targeted-perf workload
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: Add new queries to targeted-perf workload
......................................................................
Patch Set 3:
It would be good to explain that these queries are used by run-workload.py when running Impala performance tests. Also, please add a comment about any testing that was done to insure that the workloads produce the desired test runs.
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 3
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 15:55:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: IMPALA-6819: Add new queries to targeted-perf workload
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 May 2018 23:07:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: IMPALA-6819: Add new queries to targeted-perf workload
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2413/
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 May 2018 21:42:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: IMPALA-6819: Add new queries to targeted-perf workload
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 May 2018 20:07:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 )
Change subject: IMPALA-6819: Add new queries to targeted-perf workload
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415924d0bb6da1b1f5df6cb16b95a1d2eaa3ab
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Apr 2018 15:36:13 +0000
Gerrit-HasComments: No