[GitHub] [helix] zpinto commented on a diff in pull request #2497: Add support for pluggable external CloudInfoProcessor and CustomizedCloudProperties

["zpinto (via GitHub)" <gi...@apache.org>]

zpinto commented on code in PR #2497:
URL: https://github.com/apache/helix/pull/2497#discussion_r1223732062


##########
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java:
##########
@@ -242,13 +242,17 @@ private CloudInstanceInformation getCloudInstanceInformation() {
         _helixManagerProperty.getHelixCloudProperty().getCloudInfoProcessorName();
     try {
       // fetch cloud instance information for the instance
-      String cloudInstanceInformationProcessorClassName = CLOUD_PROCESSOR_PATH_PREFIX
-          + _helixManagerProperty.getHelixCloudProperty().getCloudProvider().toLowerCase() + "."
-          + cloudInstanceInformationProcessorName;
+      String cloudInstanceInformationProcessorClassName =

Review Comment:
   Yes, you are correct. The logic to construct the fully qualified path does not really belong in `ParticipantManager`. I have moved this to `HelixCloudProperty` instead. 
   
   Based on the usage of `_cloudInfoProcessorName`, I also decided to deprecate that and create `_cloudInfoProcessorFullyQualifiedClassName`.
   
   Now `ParticipantManager` will just call `getCloudInfoProcessorFullyQualifiedClassName` and attempt to load the class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org