[jira] [Commented] (ZOOKEEPER-2757) Incorrect path crashes zkCli

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016650#comment-16016650 ] 

ASF GitHub Bot commented on ZOOKEEPER-2757:
-------------------------------------------

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/240
  
    How about catch the IllegalArgumentException at ZooKeeperMain.processCmd and directly print the exception message? This way we don't need to make change to individual command.


> Incorrect path crashes zkCli
> ----------------------------
>
>                 Key: ZOOKEEPER-2757
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2757
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.3
>            Reporter: Flavio Junqueira
>            Assignee: Abraham Fine
>            Priority: Minor
>             Fix For: 3.5.4
>
>
> If I try {{delete test}} without the leading /, then the CLI crashes with this exception:
> {noformat}
> Exception in thread "main" java.lang.IllegalArgumentException: Path must start with / character
> 	at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:51)
> 	at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:1659)
> 	at org.apache.zookeeper.cli.DeleteCommand.exec(DeleteCommand.java:83)
> 	at org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:655)
> 	at org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:586)
> 	at org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:370)
> 	at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:330)
> 	at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:292)
> {noformat}
> It should really fail the operation rather than crash the CLI.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)