You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/25 08:41:53 UTC

[GitHub] [netbeans] lbruun edited a comment on pull request #2708: Migrate build from Travis CI to GitHub Actions.

lbruun edited a comment on pull request #2708:
URL: https://github.com/apache/netbeans/pull/2708#issuecomment-766648765


   Hi @KacerCZ. Great work!
   
   Yours tests for building Java8 vs Java11 seem similar to me. Perhaps you can benefit from using [Matrix Testing](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategymatrix) ?
   
   Perhaps the PR also need to be reviewed in the light of the ASF's resource limitation wrt GitHub Action Runners ? For example some tests may need to only be carried out on a cron schedule and not for every commit?  Just a thought. 
   
   Apart from that the PR clearly shows signs of optimization. Excellent.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists