You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "pivotal-jbarrett (GitHub)" <gi...@apache.org> on 2019/01/02 23:57:38 UTC

[GitHub] [geode-native] pivotal-jbarrett opened pull request #428: GEODE-6241: Makes .NET integration tests more consistent with C++

- Changes Gfsh wrapper:
 - to be more stateless.
 - use more explicit 1:1 mappings to actaual GFSH tool.
- Changes Cluster to keep more state previously held by Gfsh.
- Add support for XUnit's test output facility.

[ Full content available at: https://github.com/apache/geode-native/pull/428 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett closed pull request #428: GEODE-6241: Makes .NET integration tests more consistent with C++

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.

[ pull request closed by pivotal-jbarrett ]

[ Full content available at: https://github.com/apache/geode-native/pull/428 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] moleske commented on pull request #428: GEODE-6241: Makes .NET integration tests more consistent with C++

Posted by "moleske (GitHub)" <gi...@apache.org>.

Stray comment

[ Full content available at: https://github.com/apache/geode-native/pull/428 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] moleske commented on pull request #428: GEODE-6241: Makes .NET integration tests more consistent with C++

Posted by "moleske (GitHub)" <gi...@apache.org>.

I don't think you need `IDisposable` anymore since you removed all the code of `Dispose()` below, though I don't think it really hurts anything.

[ Full content available at: https://github.com/apache/geode-native/pull/428 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] moleske commented on pull request #428: GEODE-6241: Makes .NET integration tests more consistent with C++

Posted by "moleske (GitHub)" <gi...@apache.org>.

Just want to say I like this section, much easier to read

[ Full content available at: https://github.com/apache/geode-native/pull/428 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org