[GitHub] [spark] MaxGekk commented on a change in pull request #31455: [SPARK-34342][SQL] Format DateLiteral and TimestampLiteral toString

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #31455:
URL: https://github.com/apache/spark/pull/31455#discussion_r569306921



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -302,7 +302,15 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
     case null => "null"
     case binary: Array[Byte] => s"0x" + DatatypeConverter.printHexBinary(binary)
     case d: ArrayBasedMapData => s"map(${d.toString})"
-    case other => other.toString
+    case other =>
+      dataType match {
+        case DateType =>
+          DateTimeUtils.toJavaDate(value.asInstanceOf[Int]).toString
+        case TimestampType =>
+          DateTimeUtils.toJavaTimestamp(value.asInstanceOf[Long]).toString

Review comment:
       Would be better to convert timestamps in the session time zone.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org