You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/04/27 14:47:11 UTC
Re: Review Request 46432: RANGER-937 - Fix PMD unused local variables
issue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46432/
-----------------------------------------------------------
(Updated April 27, 2016, 12:47 p.m.)
Review request for ranger.
Summary (updated)
-----------------
RANGER-937 - Fix PMD unused local variables issue
Repository: ranger
Description
-------
Fix unused local variables issue
Diffs
-----
dev-support/ranger-pmd-ruleset.xml 96f566a
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java 69f31d8
jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java c072142
kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ca69dc0
kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 73a5830
kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 6ab91d9
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java cd866b9
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java b49cdc0
plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java f8ec8c6
ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java ad4df43
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 96ddf3f
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0706041
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 2102768
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java fbb53d2
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 5b61f71
storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormResourceMgr.java a16fce1
Diff: https://reviews.apache.org/r/46432/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 46432: RANGER-937 - Fix PMD unused local variables
issue
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On June 21, 2016, 5:54 p.m., Velmurugan Periasamy wrote:
> > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java, line 87
> > <https://reviews.apache.org/r/46432/diff/3/?file=1425193#file1425193line87>
> >
> > UDF list might be used in future?
> >
> > Madhan/Ramesh might be able to answer this.
Surely in that case we can just add it in again? It's not like we're breaking a method signature with the change.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46432/#review138883
-----------------------------------------------------------
On June 20, 2016, 11:14 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46432/
> -----------------------------------------------------------
>
> (Updated June 20, 2016, 11:14 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-937
> https://issues.apache.org/jira/browse/RANGER-937
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix unused local variables issue
>
>
> Diffs
> -----
>
> dev-support/ranger-pmd-ruleset.xml 96f566a
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java 69f31d8
> jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java c072142
> kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ca69dc0
> kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 73a5830
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java b937f0c
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java cd866b9
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java b49cdc0
> plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java f8ec8c6
> ranger-hive-utils/src/main/java/org/apache/ranger/authorization/hive/udf/RangerUdfMask.java fd8ebba
> ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java ad4df43
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java ca27580
> security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 5d0551a
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java aa5188c
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 2102768
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java fbb53d2
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 5b61f71
> storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormResourceMgr.java bf9fea3
>
> Diff: https://reviews.apache.org/r/46432/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 46432: RANGER-937 - Fix PMD unused local variables
issue
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46432/#review138883
-----------------------------------------------------------
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java
<https://reviews.apache.org/r/46432/#comment204077>
UDF list might be used in future?
Madhan/Ramesh might be able to answer this.
- Velmurugan Periasamy
On June 20, 2016, 11:14 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46432/
> -----------------------------------------------------------
>
> (Updated June 20, 2016, 11:14 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-937
> https://issues.apache.org/jira/browse/RANGER-937
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix unused local variables issue
>
>
> Diffs
> -----
>
> dev-support/ranger-pmd-ruleset.xml 96f566a
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java 69f31d8
> jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java c072142
> kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ca69dc0
> kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 73a5830
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java b937f0c
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java cd866b9
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java b49cdc0
> plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java f8ec8c6
> ranger-hive-utils/src/main/java/org/apache/ranger/authorization/hive/udf/RangerUdfMask.java fd8ebba
> ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java ad4df43
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java ca27580
> security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 5d0551a
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java aa5188c
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 2102768
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java fbb53d2
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 5b61f71
> storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormResourceMgr.java bf9fea3
>
> Diff: https://reviews.apache.org/r/46432/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 46432: RANGER-937 - Fix PMD unused local variables
issue
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46432/
-----------------------------------------------------------
(Updated June 20, 2016, 11:14 a.m.)
Review request for ranger.
Changes
-------
Rebasing.
Bugs: RANGER-937
https://issues.apache.org/jira/browse/RANGER-937
Repository: ranger
Description
-------
Fix unused local variables issue
Diffs (updated)
-----
dev-support/ranger-pmd-ruleset.xml 96f566a
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java 69f31d8
jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java c072142
kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ca69dc0
kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 73a5830
kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java b937f0c
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java cd866b9
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java b49cdc0
plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java f8ec8c6
ranger-hive-utils/src/main/java/org/apache/ranger/authorization/hive/udf/RangerUdfMask.java fd8ebba
ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java ad4df43
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java ca27580
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 5d0551a
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java aa5188c
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 2102768
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java fbb53d2
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 5b61f71
storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormResourceMgr.java bf9fea3
Diff: https://reviews.apache.org/r/46432/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 46432: RANGER-937 - Fix PMD unused local variables
issue
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46432/
-----------------------------------------------------------
(Updated May 27, 2016, 9:35 a.m.)
Review request for ranger.
Bugs: RANGER-937
https://issues.apache.org/jira/browse/RANGER-937
Repository: ranger
Description
-------
Fix unused local variables issue
Diffs (updated)
-----
dev-support/ranger-pmd-ruleset.xml 96f566a
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java 69f31d8
jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java c072142
kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ca69dc0
kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 73a5830
kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java b937f0c
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java cd866b9
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java b49cdc0
plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java f8ec8c6
ranger-hive-utils/src/main/java/org/apache/ranger/authorization/hive/udf/RangerUdfMask.java fd8ebba
ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java ad4df43
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 96f2ee3
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 4343c45
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 2102768
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java fbb53d2
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 5b61f71
storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormResourceMgr.java bf9fea3
Diff: https://reviews.apache.org/r/46432/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh