You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/29 02:23:57 UTC

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3112: [GOBBLIN-1272] Fixing bug in loading config-store when the entry is empty

autumnust commented on a change in pull request #3112:
URL: https://github.com/apache/incubator-gobblin/pull/3112#discussion_r496340378



##########
File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/ConfigStoreUtils.java
##########
@@ -260,8 +262,11 @@ public static void setTopicsFromConfigStore(Properties properties, Set<String> b
   }
 
   public static List<String> getListOfValuesFromConfigStore(Config config, String keyValue) {

Review comment:
       That's a good catch, will address.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org