You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by sebastianrothbucher <gi...@git.apache.org> on 2014/06/14 14:00:39 UTC
[GitHub] couchdb pull request: fix attachment view to bypass backbone proce...
GitHub user sebastianrothbucher opened a pull request:
https://github.com/apache/couchdb/pull/247
fix attachment view to bypass backbone processing
What did apply to the API URL a few days before also applies to viewing attachments: a data-bypass="true" needs to be added to the link pointing to an attachment. then it opens in a new window. Otherwise, an invalid URL to fauxton is constructed that goes nowhere. Test: add an attachment and try to view it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sebastianrothbucher/couchdb fix-view-attachment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #247
----
commit d210f81574bd3988c5953cd41c5d006ce553ac6c
Author: sebastianrothbucher <se...@googlemail.com>
Date: 2014-06-14T11:57:22Z
fix attachment view to bypass
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: fix attachment view to bypass backbone proce...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/247#issuecomment-46453802
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: fix attachment view to bypass backbone proce...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb/pull/247#issuecomment-46468904
Landed as 4fbeff9aca77863108535225a9a934b00e2a3b7d in master, you can close the PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: fix attachment view to bypass backbone proce...
Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher closed the pull request at:
https://github.com/apache/couchdb/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: fix attachment view to bypass backbone proce...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb/pull/247#issuecomment-46093762
Thank you! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: fix attachment view to bypass backbone proce...
Posted by andywenk <gi...@git.apache.org>.
Github user andywenk commented on the pull request:
https://github.com/apache/couchdb/pull/247#issuecomment-46454528
+1 thanks Sebastian :) looking forward to see more contributions by you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---