You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/07/23 19:30:27 UTC
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Hello Bharath Vissapragada,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11014
to review the following change.
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
IMPALA-7330. After LOAD DATA, only refresh affected partition
This changes LOAD DATA so that, if a specific partition is provided,
only the named partition will be refreshed upon completion of the
statement.
No new tests are added since this code path is covered by existing tests
and this just optimizes the metadata reload.
I did verify looking at the catalogd logs that only the single specified
partition was refreshed when I issued a LOAD statement from the shell.
Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
---
M be/src/service/client-request-state.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/11014/1
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2850/
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 24 Jul 2018 01:09:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/9/
Running initial code review checks.
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jul 2018 19:30:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jul 2018 19:54:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2850/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 21:51:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 22:39:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 24 Jul 2018 19:51:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11014/1/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:
http://gerrit.cloudera.org:8080/#/c/11014/1/be/src/service/client-request-state.cc@185
PS1, Line 185:
> nit: 4 space indent
Done
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 21:51:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/16/
Running initial code review checks.
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 21:51:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11014/1/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:
http://gerrit.cloudera.org:8080/#/c/11014/1/be/src/service/client-request-state.cc@185
PS1, Line 185:
nit: 4 space indent
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jul 2018 20:47:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
IMPALA-7330. After LOAD DATA, only refresh affected partition
This changes LOAD DATA so that, if a specific partition is provided,
only the named partition will be refreshed upon completion of the
statement.
No new tests are added since this code path is covered by existing tests
and this just optimizes the metadata reload.
I did verify looking at the catalogd logs that only the single specified
partition was refreshed when I issued a LOAD statement from the shell.
Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Reviewed-on: http://gerrit.cloudera.org:8080/11014
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M be/src/service/client-request-state.cc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 2: Code-Review+2
Forwarding +2
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 24 Jul 2018 20:45:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 )
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2855/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 24 Jul 2018 16:34:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11014
to look at the new patch set (#2).
Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition
......................................................................
IMPALA-7330. After LOAD DATA, only refresh affected partition
This changes LOAD DATA so that, if a specific partition is provided,
only the named partition will be refreshed upon completion of the
statement.
No new tests are added since this code path is covered by existing tests
and this just optimizes the metadata reload.
I did verify looking at the catalogd logs that only the single specified
partition was refreshed when I issued a LOAD statement from the shell.
Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
---
M be/src/service/client-request-state.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/11014/2
--
To view, visit http://gerrit.cloudera.org:8080/11014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>