You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/03 12:27:34 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4052: rx65n: Add missing parameters in printf

xiaoxiang781216 commented on a change in pull request #4052:
URL: https://github.com/apache/incubator-nuttx/pull/4052#discussion_r663359527



##########
File path: arch/renesas/src/rx65n/rx65n_usbdev.c
##########
@@ -2889,7 +2889,7 @@ static int rx65n_epconfigure(FAR struct usbdev_ep_s *ep,
   if (!ep || !desc)
     {
       usbtrace(TRACE_DEVERROR(RX65N_TRACEERR_INVALIDPARMS), 0);
-      printf("ERROR: ep=%p desc=%p\n");
+      printf("ERROR: ep=%p desc=%p\n", ep, desc);

Review comment:
       but it's wrong to call printf in side the code. Please create a new PR to change all printf to the macro defined in debug.h.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org