You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@vcl.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/05/30 18:41:04 UTC
[jira] [Commented] (VCL-1052) Prevent captures from failing if VM
disk mode is 'dedicated' and the repository is not configured
[ https://issues.apache.org/jira/browse/VCL-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029895#comment-16029895 ]
ASF subversion and git services commented on VCL-1052:
------------------------------------------------------
Commit 1796911 from arkurth@apache.org in branch 'vcl/trunk'
[ https://svn.apache.org/r1796911 ]
VCL-1052
Removed check for vmprofile.vmdisk = dedicated and repository path not configured in VMware.pm::capture. Added logic to VMware.pm::reclaim_vmhost_disk_space to prevent possibility of images being deleted if the repository is not configured.
Other
Added caching of return values in the following subroutines since the results are static for a given host:
* VIM_SSH.pm::get_config_option_descriptor_info
* VIM_SSH.pm::get_highest_vm_hardware_version_key
* VIM_SSH.pm::get_config_option_info
* VIM_SSH.pm::get_config_option_guest_os_info
* VIM_SSH.pm::get_supported_guest_os_ids
> Prevent captures from failing if VM disk mode is 'dedicated' and the repository is not configured
> -------------------------------------------------------------------------------------------------
>
> Key: VCL-1052
> URL: https://issues.apache.org/jira/browse/VCL-1052
> Project: VCL
> Issue Type: Improvement
> Components: vcld (backend)
> Reporter: Andy Kurth
> Assignee: Andy Kurth
> Fix For: 2.5
>
>
> VMware.pm's capture subroutine currently aborts if _vmprofile.vmdisk_ is set to _dedicated_ and the repository path is not configured. This was done to prevent _reclaim\_vmhost\_disk\_space_ from deleting image directories that may be shared with other hosts. This is a common base image creation problem since it hasn't been well-documented. The vcld.log error is:
> {noformat}
> VMware.pm:capture|660| ---- CRITICAL ----
> VMware.pm:capture|660| 2017-05-24 08:22:23VMware.pm:capture|660|disk type is set to 'dedicated' but the repository path is NOT configured for VM profile 'VMware ESXi - local storage', this configuration is not allowed because it may result in vmdk directories being deleted without a backup copy saved in the image repository
> VMware.pm:capture|660| ( 0) VMware.pm, capture (line: 660)
> VMware.pm:capture|660| (-1) image.pm, process (line: 179)
> VMware.pm:capture|660| (-2) vcld, make_new_child (line: 587)
> VMware.pm:capture|660| (-3) vcld, main (line: 348)
> {noformat}
> It would be better to add logic to _reclaim\_vmhost\_disk\_space_ to prevent possible deletion and allow captures to proceed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)