You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "Pochatkin (via GitHub)" <gi...@apache.org> on 2023/05/29 10:52:03 UTC
[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2099: IGNITE-19475 Implement JobClassLoader
Pochatkin commented on code in PR #2099:
URL: https://github.com/apache/ignite-3/pull/2099#discussion_r1209154575
##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/JobClassLoaderFactory.java:
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.compute;
+
+import java.io.IOException;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.nio.file.FileVisitResult;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.SimpleFileVisitor;
+import java.nio.file.attribute.BasicFileAttributes;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ListIterator;
+import java.util.stream.Stream;
+import org.apache.ignite.compute.DeploymentUnit;
+import org.apache.ignite.compute.version.Version;
+import org.apache.ignite.lang.ErrorGroups.Compute;
+import org.apache.ignite.lang.IgniteException;
+
+/**
+ * Creates a class loader for a job.
+ */
+public class JobClassLoaderFactory {
+
+ /**
+ * Directory for units.
+ */
+ private final Path unitsDir;
+
+ /**
+ * Constructor.
+ *
+ * @param unitsDir The directory for units.
+ */
+ public JobClassLoaderFactory(Path unitsDir) {
+ this.unitsDir = unitsDir;
+ }
+
+ /**
+ * Create a class loader for the specified units.
+ *
+ * @param units The units of the job.
+ * @return The class loader.
+ */
+ public JobClassLoader createClassLoader(List<DeploymentUnit> units) {
+ if (units.isEmpty()) {
+ throw new IllegalArgumentException("At least one unit must be specified");
+ }
+
+ ClassLoader parent = getClass().getClassLoader();
+ ListIterator<DeploymentUnit> listIterator = units.listIterator(units.size());
+ while (listIterator.hasPrevious()) {
+ parent = new JobClassLoader(collectClasspath(constructPath(listIterator.previous())), parent);
+ }
+
+ return (JobClassLoader) parent;
+ }
+
+ private Path constructPath(DeploymentUnit unit) {
+ if (unit.version().equals(Version.LATEST)) {
+ try (Stream<Path> stream = Files.list(unitsDir.resolve(unit.name()))) {
+ Version maxVersion = stream
+ .map(Path::getFileName)
+ .map(Path::toString)
+ .map(Version::parse)
+ .max(Version::compareTo)
+ .orElseThrow((() -> new IgniteException(Compute.CLASS_PATH_ERR, "Latest version not found: " + unit)));
+ return unitsDir.resolve(unit.name()).resolve(maxVersion.toString());
+ } catch (IOException e) {
+ throw new IgniteException(
+ Compute.CLASS_PATH_ERR,
+ "Failed to construct path of the unit: " + unit,
+ e
+ );
+ }
+ } else {
+ return unitsDir.resolve(unit.name()).resolve(unit.version().toString());
+ }
+ }
+
+ private static URL[] collectClasspath(Path unitDir) {
+ if (Files.notExists(unitDir)) {
+ throw new IllegalArgumentException("Unit does not exist: " + unitDir);
+ }
+
+ if (!Files.isDirectory(unitDir)) {
+ throw new IllegalArgumentException("Unit is not a directory: " + unitDir);
+ }
+
+ // Construct the "class path" for this unit
+ try {
+ ClasspathCollector classpathCollector = new ClasspathCollector(unitDir);
+ Files.walkFileTree(unitDir, classpathCollector);
+ return classpathCollector.classpath();
+ } catch (IOException e) {
+ throw new IgniteException(
+ Compute.CLASS_PATH_ERR,
+ "Failed to construct classpath for job: " + unitDir,
+ e
+ );
+ }
+ }
+
+ private static class ClasspathCollector extends SimpleFileVisitor<Path> {
+ private final List<URL> classpath = new ArrayList<>();
+
+ private ClasspathCollector(Path base) throws MalformedURLException {
Review Comment:
What the reason to add base folder to classpath?
##########
modules/api/src/main/java/org/apache/ignite/compute/version/Version.java:
##########
@@ -60,8 +60,8 @@ public String toString() {
* @param s string version representation.
* @return Version instance of
*/
- static Version parseVersion(String s) {
- if ("latest".equals(s)) {
+ static Version parse(String s) {
Review Comment:
May you please revert this rename. It produce a lot of unrelated changes.
##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/JobClassLoaderFactory.java:
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.compute;
+
+import java.io.IOException;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.nio.file.FileVisitResult;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.SimpleFileVisitor;
+import java.nio.file.attribute.BasicFileAttributes;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ListIterator;
+import java.util.stream.Stream;
+import org.apache.ignite.compute.DeploymentUnit;
+import org.apache.ignite.compute.version.Version;
+import org.apache.ignite.lang.ErrorGroups.Compute;
+import org.apache.ignite.lang.IgniteException;
+
+/**
+ * Creates a class loader for a job.
+ */
+public class JobClassLoaderFactory {
+
+ /**
+ * Directory for units.
+ */
+ private final Path unitsDir;
+
+ /**
+ * Constructor.
+ *
+ * @param unitsDir The directory for units.
+ */
+ public JobClassLoaderFactory(Path unitsDir) {
+ this.unitsDir = unitsDir;
+ }
+
+ /**
+ * Create a class loader for the specified units.
+ *
+ * @param units The units of the job.
+ * @return The class loader.
+ */
+ public JobClassLoader createClassLoader(List<DeploymentUnit> units) {
+ if (units.isEmpty()) {
+ throw new IllegalArgumentException("At least one unit must be specified");
+ }
+
+ ClassLoader parent = getClass().getClassLoader();
+ ListIterator<DeploymentUnit> listIterator = units.listIterator(units.size());
+ while (listIterator.hasPrevious()) {
+ parent = new JobClassLoader(collectClasspath(constructPath(listIterator.previous())), parent);
+ }
+
+ return (JobClassLoader) parent;
+ }
+
+ private Path constructPath(DeploymentUnit unit) {
+ if (unit.version().equals(Version.LATEST)) {
+ try (Stream<Path> stream = Files.list(unitsDir.resolve(unit.name()))) {
+ Version maxVersion = stream
+ .map(Path::getFileName)
+ .map(Path::toString)
+ .map(Version::parse)
+ .max(Version::compareTo)
+ .orElseThrow((() -> new IgniteException(Compute.CLASS_PATH_ERR, "Latest version not found: " + unit)));
Review Comment:
Please do not use local file system files for version compute. Please extract it to Function field. It shouldbe computed via unit meta.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org