[GitHub] [ignite-3] zstan commented on a diff in pull request #1501: IGNITE-17951 Sql. Enlist partitions in transaction when preparing the execution plan.

["zstan (via GitHub)" <gi...@apache.org>]

zstan commented on code in PR #1501:
URL: https://github.com/apache/ignite-3/pull/1501#discussion_r1087537833


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/IndexScanNode.java:
##########
@@ -85,6 +89,7 @@ public IndexScanNode(
             IgniteIndex schemaIndex,
             InternalIgniteTable schemaTable,
             int[] parts,
+            long @Nullable[] terms,

Review Comment:
   ups, is it good idea to mix raft internals and execution node ? probably we can some facade if it`s necessarily ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org