You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/02 09:15:01 UTC
[GitHub] [kafka] rajinisivaram opened a new pull request #11161: MINOR: Remove node from API versions cache on NetworkClient.close(nodeId)
rajinisivaram opened a new pull request #11161:
URL: https://github.com/apache/kafka/pull/11161
We clear the two collections that track API version requests when server disconnects, but not for local close. The PR clears them for local close as well.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11161: MINOR: Remove node from API versions cache on NetworkClient.close(nodeId)
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11161:
URL: https://github.com/apache/kafka/pull/11161#issuecomment-1030533145
@rajinisivaram friendly ping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #11161: MINOR: Remove node from API versions cache on NetworkClient.close(nodeId)
Posted by GitBox <gi...@apache.org>.
dajac commented on a change in pull request #11161:
URL: https://github.com/apache/kafka/pull/11161#discussion_r685277294
##########
File path: clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
##########
@@ -198,6 +200,10 @@ public void testClose() {
assertFalse(client.hasInFlightRequests(node.idString()));
assertFalse(client.hasInFlightRequests());
assertFalse(client.isReady(node, 0), "Connection should not be ready after close");
+ ApiVersions apiVersions = TestUtils.fieldValue(client, NetworkClient.class, "apiVersions");
Review comment:
nit: There is an extra space before `=` here and below.
I am not a huge fan of using `TestUtils.fieldValue`. Did you consider making both attributes package private or something like this instead? `ApiVersions` is passed to the constructor of `NetworkClient` so we could access it this way as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11161: MINOR: Remove node from API versions cache on NetworkClient.close(nodeId)
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11161:
URL: https://github.com/apache/kafka/pull/11161#issuecomment-940090124
@rajinisivaram Do you still plan to get this PR merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org