You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dannycranmer (via GitHub)" <gi...@apache.org> on 2023/02/23 13:13:59 UTC

[GitHub] [flink] dannycranmer opened a new pull request, #22008: [FLINK-31183][Connector/Kinesis] Fix bug where EFO Consumer can fail …

dannycranmer opened a new pull request, #22008:
URL: https://github.com/apache/flink/pull/22008

   …to stop gracefully during stop-with-savepoint
   
   ## What is the purpose of the change
   
   Update Kinesis EFO consumer to exit gracefully during stop-with-savepoint. There is an edgecase where an exception is thrown causing the job to fail during stop-with-savepoint.
   
   ## Brief change log
   
   - Add a callback to `FanoutShardSubscriber` that allows the EFO subscriber threads to check if the consumer should be running
   
   ## Verifying this change
   
   - Additional unit tests added
   - Manually verified via Flink cluster using stop-with-savepoint
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dannycranmer merged pull request #22008: [FLINK-31183][Connector/Kinesis] Fix bug where EFO Consumer can fail …

Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #22008:
URL: https://github.com/apache/flink/pull/22008


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22008: [FLINK-31183][Connector/Kinesis] Fix bug where EFO Consumer can fail …

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22008:
URL: https://github.com/apache/flink/pull/22008#issuecomment-1441770151

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6186ce2f09c80bbbccfc76829700cd6413b803fc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6186ce2f09c80bbbccfc76829700cd6413b803fc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6186ce2f09c80bbbccfc76829700cd6413b803fc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org