You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/04/07 04:33:27 UTC
[GitHub] [datasketches-java] leerho opened a new pull request, #391: Direct kll double v2
leerho opened a new pull request, #391:
URL: https://github.com/apache/datasketches-java/pull/391
This has been refactored to this hierarchy:
KllSketch
public KllDoublesSketch <- polymorphic
KllHeapDoublesSketch
KllDirectDoublesSketch
public KllFloatsSketch <- polymorphic
KllHeapFloatsSketch
KllDirectFloatsSketch
It probably needs some fine tuning, but I'd like you to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho commented on pull request #391: Direct kll double v2
Posted by GitBox <gi...@apache.org>.
leerho commented on PR #391:
URL: https://github.com/apache/datasketches-java/pull/391#issuecomment-1099806467
The LGTM is failing due to some internal issue: "[ERROR] Spawned process exited abnormally..."
Retried multiple times. It doesn't seem to be related to this code at all. So I'm going to ignore this error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho commented on pull request #391: Direct kll double v2
Posted by GitBox <gi...@apache.org>.
leerho commented on PR #391:
URL: https://github.com/apache/datasketches-java/pull/391#issuecomment-1099763711
This has been refactored to this Hierarchy:
```
KllSketch
public KllDoublesSketch <- polymorphic
KllHeapDoublesSketch
KllDirectDoublesSketch
KllDirectCompactDoublesSketch
public KllFloatsSketch <- polymorphic
KllHeapFloatsSketch
KllDirectFloatsSketch
KllDirectCompactFloatsSketch
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] lgtm-com[bot] commented on pull request #391: Direct kll double v2
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on PR #391:
URL: https://github.com/apache/datasketches-java/pull/391#issuecomment-1099731779
This pull request **introduces 1 alert** when merging 8f01cbd33187030f26bf5f7ae035892b088ec940 into 53cbfa964d782febb7be034b5ca68bae2f2cbbf5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/datasketches-java/rev/pr-4ef3f9e03c048f1063675cb060a3d1d09780bcad)
**new alerts:**
* 1 for Spurious Javadoc @param tags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho merged pull request #391: Direct kll double v2
Posted by GitBox <gi...@apache.org>.
leerho merged PR #391:
URL: https://github.com/apache/datasketches-java/pull/391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org