You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by be...@apache.org on 2010/05/21 14:11:15 UTC

svn commit: r946979 - in /maven/core-integration-testing/trunk/core-it-suite/src/test: java/org/apache/maven/it/ resources/mng-4684/

Author: bentmann
Date: Fri May 21 12:11:15 2010
New Revision: 946979

URL: http://svn.apache.org/viewvc?rev=946979&view=rev
Log:
[MNG-4684] distributionManagment section in profiles do not override default one (maven 3 regression)

o Added IT

Added:
    maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4684DistMngtOverridenByProfileTest.java   (with props)
    maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-4684/
    maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-4684/pom.xml   (with props)
Modified:
    maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java

Modified: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java?rev=946979&r1=946978&r2=946979&view=diff
==============================================================================
--- maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java (original)
+++ maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java Fri May 21 12:11:15 2010
@@ -82,6 +82,7 @@ public class IntegrationTestSuite
         // suite.addTestSuite( MavenIT0109ReleaseUpdateTest.class );
         // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137
 
+        suite.addTestSuite( MavenITmng4684DistMngtOverridenByProfileTest.class );
         suite.addTestSuite( MavenITmng4679SnapshotUpdateInPluginTest.class );
         suite.addTestSuite( MavenITmng4677DisabledPluginConfigInheritanceTest.class );
         suite.addTestSuite( MavenITmng4666CoreRealmImportTest.class );

Added: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4684DistMngtOverridenByProfileTest.java
URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4684DistMngtOverridenByProfileTest.java?rev=946979&view=auto
==============================================================================
--- maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4684DistMngtOverridenByProfileTest.java (added)
+++ maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4684DistMngtOverridenByProfileTest.java Fri May 21 12:11:15 2010
@@ -0,0 +1,77 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.Properties;
+
+/**
+ * This is a test set for <a href="http://jira.codehaus.org/browse/MNG-4684">MNG-4684</a>.
+ * 
+ * @author Benjamin Bentmann
+ */
+public class MavenITmng4684DistMngtOverridenByProfileTest
+    extends AbstractMavenIntegrationTestCase
+{
+
+    public MavenITmng4684DistMngtOverridenByProfileTest()
+    {
+        super( "[2.0.3,3.0-alpha-1),[3.0-beta-2,)" );
+    }
+
+    /**
+     * Verify that active profiles can override distribution management settings.
+     */
+    public void testit()
+        throws Exception
+    {
+        File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4684" );
+
+        Verifier verifier = new Verifier( testDir.getAbsolutePath() );
+        verifier.setAutoclean( false );
+        verifier.deleteDirectory( "target" );
+        verifier.getCliOptions().add( "-Pmng4684" );
+        verifier.executeGoal( "validate" );
+        verifier.verifyErrorFreeLog();
+        verifier.resetStreams();
+
+        Properties props = verifier.loadProperties( "target/pom.properties" );
+
+        assertEquals( "pr", props.getProperty( "project.distributionManagement.repository.id" ) );
+        assertEquals( "http://localhost/r", props.getProperty( "project.distributionManagement.repository.url" ) );
+        assertEquals( "", props.getProperty( "project.distributionManagement.repository.name", "" ) );
+        assertEquals( "default", props.getProperty( "project.distributionManagement.repository.layout" ) );
+        assertEquals( "true", props.getProperty( "project.distributionManagement.repository.uniqueVersion" ) );
+
+        assertEquals( "psr", props.getProperty( "project.distributionManagement.snapshotRepository.id" ) );
+        assertEquals( "http://localhost/sr", props.getProperty( "project.distributionManagement.snapshotRepository.url" ) );
+        assertEquals( "", props.getProperty( "project.distributionManagement.snapshotRepository.name", "" ) );
+        assertEquals( "default", props.getProperty( "project.distributionManagement.snapshotRepository.layout" ) );
+        assertEquals( "true", props.getProperty( "project.distributionManagement.snapshotRepository.uniqueVersion" ) );
+
+        assertEquals( "ps", props.getProperty( "project.distributionManagement.site.id" ) );
+        assertEquals( "http://localhost/s", props.getProperty( "project.distributionManagement.site.url" ) );
+        assertEquals( "passed", props.getProperty( "project.distributionManagement.site.name" ) );
+    }
+
+}

Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4684DistMngtOverridenByProfileTest.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4684DistMngtOverridenByProfileTest.java
------------------------------------------------------------------------------
    svn:keywords = Author Date Id Revision

Added: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-4684/pom.xml
URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-4684/pom.xml?rev=946979&view=auto
==============================================================================
--- maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-4684/pom.xml (added)
+++ maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-4684/pom.xml Fri May 21 12:11:15 2010
@@ -0,0 +1,102 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>org.apache.maven.its.mng4684</groupId>
+  <artifactId>test</artifactId>
+  <version>0.1</version>
+  <packaging>pom</packaging>
+
+  <name>Maven Integration Test :: MNG-4684</name>
+  <description>
+    Verify that active profiles can override distribution management settings.
+  </description>
+
+  <distributionManagement>
+    <repository>
+      <id>test</id>
+      <url>http://localhost/void</url>
+      <name>test</name>
+      <layout>legacy</layout>
+      <uniqueVersion>false</uniqueVersion>
+    </repository>
+    <snapshotRepository>
+      <id>test</id>
+      <url>http://localhost/void</url>
+      <name>test</name>
+      <layout>legacy</layout>
+      <uniqueVersion>false</uniqueVersion>
+    </snapshotRepository>
+    <site>
+      <id>test</id>
+      <url>http://localhost/void</url>
+      <name>test</name>
+    </site>
+  </distributionManagement>
+
+  <profiles>
+    <profile>
+      <id>mng4684</id>
+      <distributionManagement>
+        <repository>
+          <id>pr</id>
+          <url>http://localhost/r</url>
+        </repository>
+        <snapshotRepository>
+          <id>psr</id>
+          <url>http://localhost/sr</url>
+        </snapshotRepository>
+        <site>
+          <id>ps</id>
+          <url>http://localhost/s</url>
+          <name>passed</name>
+        </site>
+      </distributionManagement>
+    </profile>
+  </profiles>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.its.plugins</groupId>
+        <artifactId>maven-it-plugin-expression</artifactId>
+        <version>2.1-SNAPSHOT</version>
+        <configuration>
+          <outputFile>target/pom.properties</outputFile>
+          <expressions>
+            <expression>project/distributionManagement</expression>
+          </expressions>
+        </configuration>
+        <executions>
+          <execution>
+            <id>test</id>
+            <phase>validate</phase>
+            <goals>
+              <goal>eval</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>

Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-4684/pom.xml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-4684/pom.xml
------------------------------------------------------------------------------
    svn:keywords = Author Date Id Revision