You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/10/19 20:18:28 UTC

Review Request 63165: Add banner pointing to new UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63165/
-----------------------------------------------------------

Review request for Aurora, Santhosh Kumar Shanmugham and Bill Farner.


Repository: aurora


Description
-------

We'd like to direct all of our users to the new UI in order to do a thorough beta test. It's a little ham-handed but the idea is this would be removed and the old UI completely replaced by the next official Scheduler release. So only those brave souls deploying from master would see this.


Diffs
-----

  src/main/resources/scheduler/assets/css/app.css 67a0ac5b3fa6372867e6bc2d963a3867dda6748b 
  src/main/resources/scheduler/assets/scheduler/index.html 98e465a46c006bcfea765a4530fc5d6d67bd1539 


Diff: https://reviews.apache.org/r/63165/diff/1/


Testing
-------

See screenshot.


File Attachments
----------------

Screen Shot 2017-10-19 at 1.16.35 PM.png
  https://reviews.apache.org/media/uploaded/files/2017/10/19/9dd8eccb-c983-427a-a41e-d236f1f3b2a5__Screen_Shot_2017-10-19_at_1.16.35_PM.png


Thanks,

David McLaughlin

Re: Review Request 63165: Add banner pointing to new UI

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63165/#review188757
-----------------------------------------------------------



Master (a9827fe) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 19, 2017, 8:18 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63165/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 8:18 p.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We'd like to direct all of our users to the new UI in order to do a thorough beta test. It's a little ham-handed but the idea is this would be removed and the old UI completely replaced by the next official Scheduler release. So only those brave souls deploying from master would see this.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/css/app.css 67a0ac5b3fa6372867e6bc2d963a3867dda6748b 
>   src/main/resources/scheduler/assets/scheduler/index.html 98e465a46c006bcfea765a4530fc5d6d67bd1539 
> 
> 
> Diff: https://reviews.apache.org/r/63165/diff/1/
> 
> 
> Testing
> -------
> 
> See screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-19 at 1.16.35 PM.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/19/9dd8eccb-c983-427a-a41e-d236f1f3b2a5__Screen_Shot_2017-10-19_at_1.16.35_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 63165: Add banner pointing to new UI

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63165/#review188748
-----------------------------------------------------------


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On Oct. 19, 2017, 1:18 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63165/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 1:18 p.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We'd like to direct all of our users to the new UI in order to do a thorough beta test. It's a little ham-handed but the idea is this would be removed and the old UI completely replaced by the next official Scheduler release. So only those brave souls deploying from master would see this.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/css/app.css 67a0ac5b3fa6372867e6bc2d963a3867dda6748b 
>   src/main/resources/scheduler/assets/scheduler/index.html 98e465a46c006bcfea765a4530fc5d6d67bd1539 
> 
> 
> Diff: https://reviews.apache.org/r/63165/diff/1/
> 
> 
> Testing
> -------
> 
> See screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-19 at 1.16.35 PM.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/19/9dd8eccb-c983-427a-a41e-d236f1f3b2a5__Screen_Shot_2017-10-19_at_1.16.35_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>