You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/11/12 13:49:51 UTC
[GitHub] [cordova-android] timbru31 commented on a change in pull request #1117: Android - allow changing min sdk version
timbru31 commented on a change in pull request #1117:
URL: https://github.com/apache/cordova-android/pull/1117#discussion_r522117778
##########
File path: framework/build.gradle
##########
@@ -20,6 +20,12 @@ ext {
apply from: 'cordova.gradle'
cdvCompileSdkVersion = privateHelpers.getProjectTarget()
cdvBuildToolsVersion = privateHelpers.findLatestInstalledBuildTools()
+ if (project.hasProperty('cdvMinSdkVersion')) {
Review comment:
Shouldn't we guard it with a check that the given string is indeed an integer?
##########
File path: framework/build.gradle
##########
@@ -20,6 +20,12 @@ ext {
apply from: 'cordova.gradle'
cdvCompileSdkVersion = privateHelpers.getProjectTarget()
cdvBuildToolsVersion = privateHelpers.findLatestInstalledBuildTools()
+ if (project.hasProperty('cdvMinSdkVersion')) {
+ cdvMinSdkVersion = Integer.parseInt('' + cdvMinSdkVersion)
+ println "[Cordova] cdvMinSdkVersion is overridden, try it at your own risk."
Review comment:
The log statement should use single quotes.
##########
File path: framework/build.gradle
##########
@@ -20,6 +20,12 @@ ext {
apply from: 'cordova.gradle'
cdvCompileSdkVersion = privateHelpers.getProjectTarget()
cdvBuildToolsVersion = privateHelpers.findLatestInstalledBuildTools()
+ if (project.hasProperty('cdvMinSdkVersion')) {
+ cdvMinSdkVersion = Integer.parseInt('' + cdvMinSdkVersion)
Review comment:
AFAIK Gradle's syntax is simply `cdvMinSdkVersion as int`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org