[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2803: ARTEMIS-2458 Fix AMQP Transaction Rollback Ordering

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2803: ARTEMIS-2458 Fix AMQP Transaction Rollback Ordering
URL: https://github.com/apache/activemq-artemis/pull/2803#discussion_r315931315
 
 

 ##########
 File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/transaction/ProtonTransactionHandler.java
 ##########
 @@ -165,6 +170,16 @@ public void onError(int errorCode, String errorMessage) {
       }
    }
 
+   private void cancelRefs(ProtonTransactionImpl tx) throws Exception {
+      List<MessageReference> toCancel = new ArrayList<>();
 
 Review comment:
   The only bit i wonder if we need to add here is the extra logic of stopping and restarting the consumer as like in ServerSessionImpl::cancelAndRollback
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services