You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/06/26 20:35:18 UTC
Review Request 35937: Windows unit tests: Common unit tests: fix the
imports & failing patches
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35937/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk and Jayush Luniya.
Bugs: AMBARI-12171
https://issues.apache.org/jira/browse/AMBARI-12171
Repository: ambari
Description
-------
Fixed the imports. Coalesced the OS mock.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestContentSources.py c144cf9fe3c977e94d0e447510bfe64849944e5c
ambari-agent/src/test/python/resource_management/TestDirectoryResource.py e57ed675580404480563f026a90ef77bc497726e
ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 6bb9d0f3ce8acfbba9d358a3595f9516299b0daa
ambari-agent/src/test/python/resource_management/TestExecuteResource.py 04244e94e6b23237a9b9a0c08a0f436e5e5f1bcd
ambari-agent/src/test/python/resource_management/TestFileResource.py 43df94f8893f83b744655f6063e4f699ae4d4596
ambari-agent/src/test/python/resource_management/TestGroupResource.py 1d52a90d7ea5012bec09cc93b4dec1062aa6b358
ambari-agent/src/test/python/resource_management/TestLinkResource.py ceac07603af7783ca4b0fd3aa7186f4f1786c7bd
ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py 5c97380ab8da2047358493b4500ff0c5d9bc0da1
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 0f3017865c215adbd6e88806e9b0fa14ac1805cb
ambari-agent/src/test/python/resource_management/TestServiceResource.py cf922784cae001fffa7490f6f0739ac0eddf035f
ambari-agent/src/test/python/resource_management/TestTemplateConfigResource.py 2808e63c82d75737d0a18e942a531af5bcdd29f0
ambari-agent/src/test/python/resource_management/TestUserResource.py 1598823180145d00c8657196c07e47e0c7d2da85
ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py 609271752f46d746dd62a2a36816f7ebfbac86fa
ambari-agent/src/test/python/unitTests.py b6f84116d6b3521637b178ce77b9d6943cb7c31d
Diff: https://reviews.apache.org/r/35937/diff/
Testing
-------
mvn clean test on Linux and Windows
Thanks,
Florian Barca
Re: Review Request 35937: Windows unit tests: Common unit tests: fix
the imports & failing patches
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35937/#review91973
-----------------------------------------------------------
hw11039:ambari jluniya$ git apply ~/Downloads/AMBARI-12171.0.patch
error: patch failed: ambari-agent/src/test/python/unitTests.py:29
error: ambari-agent/src/test/python/unitTests.py: patch does not apply
- Jayush Luniya
On June 26, 2015, 9:07 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35937/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 9:07 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
>
>
> Bugs: AMBARI-12171
> https://issues.apache.org/jira/browse/AMBARI-12171
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed the imports. Coalesced the OS mock.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestContentSources.py c144cf9fe3c977e94d0e447510bfe64849944e5c
> ambari-agent/src/test/python/resource_management/TestDirectoryResource.py e57ed675580404480563f026a90ef77bc497726e
> ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 6bb9d0f3ce8acfbba9d358a3595f9516299b0daa
> ambari-agent/src/test/python/resource_management/TestExecuteResource.py 04244e94e6b23237a9b9a0c08a0f436e5e5f1bcd
> ambari-agent/src/test/python/resource_management/TestFileResource.py 43df94f8893f83b744655f6063e4f699ae4d4596
> ambari-agent/src/test/python/resource_management/TestGroupResource.py 1d52a90d7ea5012bec09cc93b4dec1062aa6b358
> ambari-agent/src/test/python/resource_management/TestLinkResource.py ceac07603af7783ca4b0fd3aa7186f4f1786c7bd
> ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py 5c97380ab8da2047358493b4500ff0c5d9bc0da1
> ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 0f3017865c215adbd6e88806e9b0fa14ac1805cb
> ambari-agent/src/test/python/resource_management/TestServiceResource.py cf922784cae001fffa7490f6f0739ac0eddf035f
> ambari-agent/src/test/python/resource_management/TestTemplateConfigResource.py 2808e63c82d75737d0a18e942a531af5bcdd29f0
> ambari-agent/src/test/python/resource_management/TestUserResource.py 1598823180145d00c8657196c07e47e0c7d2da85
> ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py 609271752f46d746dd62a2a36816f7ebfbac86fa
> ambari-agent/src/test/python/unitTests.py b6f84116d6b3521637b178ce77b9d6943cb7c31d
>
> Diff: https://reviews.apache.org/r/35937/diff/
>
>
> Testing
> -------
>
> mvn clean test on Linux and Windows
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 35937: Windows unit tests: Common unit tests: fix
the imports & failing patches
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35937/#review92458
-----------------------------------------------------------
Ship it!
Ship It!
- Artem Baranchuk
On Июль 21, 2015, 6:31 п.п., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35937/
> -----------------------------------------------------------
>
> (Updated Июль 21, 2015, 6:31 п.п.)
>
>
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
>
>
> Bugs: AMBARI-12171
> https://issues.apache.org/jira/browse/AMBARI-12171
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed the imports. Coalesced the OS mock.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestContentSources.py c144cf9fe3c977e94d0e447510bfe64849944e5c
> ambari-agent/src/test/python/resource_management/TestDirectoryResource.py e57ed675580404480563f026a90ef77bc497726e
> ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 6bb9d0f3ce8acfbba9d358a3595f9516299b0daa
> ambari-agent/src/test/python/resource_management/TestExecuteResource.py 04244e94e6b23237a9b9a0c08a0f436e5e5f1bcd
> ambari-agent/src/test/python/resource_management/TestFileResource.py 43df94f8893f83b744655f6063e4f699ae4d4596
> ambari-agent/src/test/python/resource_management/TestGroupResource.py 1d52a90d7ea5012bec09cc93b4dec1062aa6b358
> ambari-agent/src/test/python/resource_management/TestLinkResource.py ceac07603af7783ca4b0fd3aa7186f4f1786c7bd
> ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py 5c97380ab8da2047358493b4500ff0c5d9bc0da1
> ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 0f3017865c215adbd6e88806e9b0fa14ac1805cb
> ambari-agent/src/test/python/resource_management/TestServiceResource.py cf922784cae001fffa7490f6f0739ac0eddf035f
> ambari-agent/src/test/python/resource_management/TestTemplateConfigResource.py 2808e63c82d75737d0a18e942a531af5bcdd29f0
> ambari-agent/src/test/python/resource_management/TestUserResource.py 1598823180145d00c8657196c07e47e0c7d2da85
> ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py 609271752f46d746dd62a2a36816f7ebfbac86fa
> ambari-agent/src/test/python/unitTests.py 83b5a0fc551804dd13c226aca6fb3a20cbe6d478
>
> Diff: https://reviews.apache.org/r/35937/diff/
>
>
> Testing
> -------
>
> mvn clean test on Linux and Windows
>
> Verified on Mac:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 1.457 s]
> [INFO] Ambari Web ......................................... SUCCESS [ 37.300 s]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.586 s]
> [INFO] Ambari Admin View .................................. SUCCESS [ 14.236 s]
> [INFO] ambari-metrics ..................................... SUCCESS [ 1.407 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 1.925 s]
> [INFO] Ambari Metrics Hadoop Sink ......................... SUCCESS [ 4.639 s]
> [INFO] Ambari Metrics Flume Sink .......................... SUCCESS [ 2.385 s]
> [INFO] Ambari Metrics Kafka Sink .......................... SUCCESS [ 3.839 s]
> [INFO] Ambari Metrics Storm Sink .......................... SUCCESS [ 3.233 s]
> [INFO] Ambari Metrics Collector ........................... SUCCESS [05:44 min]
> [INFO] Ambari Metrics Monitor ............................. SUCCESS [ 3.088 s]
> [INFO] Ambari Metrics Assembly ............................ SUCCESS [01:41 min]
> [INFO] Ambari Server ...................................... SUCCESS [02:10 min]
> [INFO] Ambari Agent ....................................... SUCCESS [ 13.457 s]
> [INFO] Ambari Client ...................................... SUCCESS [ 0.050 s]
> [INFO] Ambari Python Client ............................... SUCCESS [ 1.140 s]
> [INFO] Ambari Groovy Client ............................... SUCCESS [ 10.051 s]
> [INFO] Ambari Shell ....................................... SUCCESS [ 0.039 s]
> [INFO] Ambari Python Shell ................................ SUCCESS [ 0.454 s]
> [INFO] Ambari Groovy Shell ................................ SUCCESS [ 7.054 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 11:25 min
> [INFO] Finished at: 2015-07-21T11:19:21-07:00
> [INFO] Final Memory: 160M/1005M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 35937: Windows unit tests: Common unit tests: fix
the imports & failing patches
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35937/
-----------------------------------------------------------
(Updated July 21, 2015, 6:31 p.m.)
Review request for Ambari, Artem Baranchuk and Jayush Luniya.
Bugs: AMBARI-12171
https://issues.apache.org/jira/browse/AMBARI-12171
Repository: ambari
Description
-------
Fixed the imports. Coalesced the OS mock.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestContentSources.py c144cf9fe3c977e94d0e447510bfe64849944e5c
ambari-agent/src/test/python/resource_management/TestDirectoryResource.py e57ed675580404480563f026a90ef77bc497726e
ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 6bb9d0f3ce8acfbba9d358a3595f9516299b0daa
ambari-agent/src/test/python/resource_management/TestExecuteResource.py 04244e94e6b23237a9b9a0c08a0f436e5e5f1bcd
ambari-agent/src/test/python/resource_management/TestFileResource.py 43df94f8893f83b744655f6063e4f699ae4d4596
ambari-agent/src/test/python/resource_management/TestGroupResource.py 1d52a90d7ea5012bec09cc93b4dec1062aa6b358
ambari-agent/src/test/python/resource_management/TestLinkResource.py ceac07603af7783ca4b0fd3aa7186f4f1786c7bd
ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py 5c97380ab8da2047358493b4500ff0c5d9bc0da1
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 0f3017865c215adbd6e88806e9b0fa14ac1805cb
ambari-agent/src/test/python/resource_management/TestServiceResource.py cf922784cae001fffa7490f6f0739ac0eddf035f
ambari-agent/src/test/python/resource_management/TestTemplateConfigResource.py 2808e63c82d75737d0a18e942a531af5bcdd29f0
ambari-agent/src/test/python/resource_management/TestUserResource.py 1598823180145d00c8657196c07e47e0c7d2da85
ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py 609271752f46d746dd62a2a36816f7ebfbac86fa
ambari-agent/src/test/python/unitTests.py 83b5a0fc551804dd13c226aca6fb3a20cbe6d478
Diff: https://reviews.apache.org/r/35937/diff/
Testing (updated)
-------
mvn clean test on Linux and Windows
Verified on Mac:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Ambari Project POM .......................... SUCCESS [ 1.457 s]
[INFO] Ambari Web ......................................... SUCCESS [ 37.300 s]
[INFO] Ambari Views ....................................... SUCCESS [ 2.586 s]
[INFO] Ambari Admin View .................................. SUCCESS [ 14.236 s]
[INFO] ambari-metrics ..................................... SUCCESS [ 1.407 s]
[INFO] Ambari Metrics Common .............................. SUCCESS [ 1.925 s]
[INFO] Ambari Metrics Hadoop Sink ......................... SUCCESS [ 4.639 s]
[INFO] Ambari Metrics Flume Sink .......................... SUCCESS [ 2.385 s]
[INFO] Ambari Metrics Kafka Sink .......................... SUCCESS [ 3.839 s]
[INFO] Ambari Metrics Storm Sink .......................... SUCCESS [ 3.233 s]
[INFO] Ambari Metrics Collector ........................... SUCCESS [05:44 min]
[INFO] Ambari Metrics Monitor ............................. SUCCESS [ 3.088 s]
[INFO] Ambari Metrics Assembly ............................ SUCCESS [01:41 min]
[INFO] Ambari Server ...................................... SUCCESS [02:10 min]
[INFO] Ambari Agent ....................................... SUCCESS [ 13.457 s]
[INFO] Ambari Client ...................................... SUCCESS [ 0.050 s]
[INFO] Ambari Python Client ............................... SUCCESS [ 1.140 s]
[INFO] Ambari Groovy Client ............................... SUCCESS [ 10.051 s]
[INFO] Ambari Shell ....................................... SUCCESS [ 0.039 s]
[INFO] Ambari Python Shell ................................ SUCCESS [ 0.454 s]
[INFO] Ambari Groovy Shell ................................ SUCCESS [ 7.054 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:25 min
[INFO] Finished at: 2015-07-21T11:19:21-07:00
[INFO] Final Memory: 160M/1005M
[INFO] ------------------------------------------------------------------------
Thanks,
Florian Barca
Re: Review Request 35937: Windows unit tests: Common unit tests: fix
the imports & failing patches
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35937/
-----------------------------------------------------------
(Updated July 16, 2015, 10:38 p.m.)
Review request for Ambari, Artem Baranchuk and Jayush Luniya.
Bugs: AMBARI-12171
https://issues.apache.org/jira/browse/AMBARI-12171
Repository: ambari
Description
-------
Fixed the imports. Coalesced the OS mock.
Diffs (updated)
-----
ambari-agent/src/test/python/resource_management/TestContentSources.py c144cf9fe3c977e94d0e447510bfe64849944e5c
ambari-agent/src/test/python/resource_management/TestDirectoryResource.py e57ed675580404480563f026a90ef77bc497726e
ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 6bb9d0f3ce8acfbba9d358a3595f9516299b0daa
ambari-agent/src/test/python/resource_management/TestExecuteResource.py 04244e94e6b23237a9b9a0c08a0f436e5e5f1bcd
ambari-agent/src/test/python/resource_management/TestFileResource.py 43df94f8893f83b744655f6063e4f699ae4d4596
ambari-agent/src/test/python/resource_management/TestGroupResource.py 1d52a90d7ea5012bec09cc93b4dec1062aa6b358
ambari-agent/src/test/python/resource_management/TestLinkResource.py ceac07603af7783ca4b0fd3aa7186f4f1786c7bd
ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py 5c97380ab8da2047358493b4500ff0c5d9bc0da1
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 0f3017865c215adbd6e88806e9b0fa14ac1805cb
ambari-agent/src/test/python/resource_management/TestServiceResource.py cf922784cae001fffa7490f6f0739ac0eddf035f
ambari-agent/src/test/python/resource_management/TestTemplateConfigResource.py 2808e63c82d75737d0a18e942a531af5bcdd29f0
ambari-agent/src/test/python/resource_management/TestUserResource.py 1598823180145d00c8657196c07e47e0c7d2da85
ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py 609271752f46d746dd62a2a36816f7ebfbac86fa
ambari-agent/src/test/python/unitTests.py 83b5a0fc551804dd13c226aca6fb3a20cbe6d478
Diff: https://reviews.apache.org/r/35937/diff/
Testing
-------
mvn clean test on Linux and Windows
Thanks,
Florian Barca
Re: Review Request 35937: Windows unit tests: Common unit tests: fix
the imports & failing patches
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35937/
-----------------------------------------------------------
(Updated June 26, 2015, 9:07 p.m.)
Review request for Ambari, Artem Baranchuk and Jayush Luniya.
Summary (updated)
-----------------
Windows unit tests: Common unit tests: fix the imports & failing patches
Bugs: AMBARI-12171
https://issues.apache.org/jira/browse/AMBARI-12171
Repository: ambari
Description
-------
Fixed the imports. Coalesced the OS mock.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestContentSources.py c144cf9fe3c977e94d0e447510bfe64849944e5c
ambari-agent/src/test/python/resource_management/TestDirectoryResource.py e57ed675580404480563f026a90ef77bc497726e
ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 6bb9d0f3ce8acfbba9d358a3595f9516299b0daa
ambari-agent/src/test/python/resource_management/TestExecuteResource.py 04244e94e6b23237a9b9a0c08a0f436e5e5f1bcd
ambari-agent/src/test/python/resource_management/TestFileResource.py 43df94f8893f83b744655f6063e4f699ae4d4596
ambari-agent/src/test/python/resource_management/TestGroupResource.py 1d52a90d7ea5012bec09cc93b4dec1062aa6b358
ambari-agent/src/test/python/resource_management/TestLinkResource.py ceac07603af7783ca4b0fd3aa7186f4f1786c7bd
ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py 5c97380ab8da2047358493b4500ff0c5d9bc0da1
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 0f3017865c215adbd6e88806e9b0fa14ac1805cb
ambari-agent/src/test/python/resource_management/TestServiceResource.py cf922784cae001fffa7490f6f0739ac0eddf035f
ambari-agent/src/test/python/resource_management/TestTemplateConfigResource.py 2808e63c82d75737d0a18e942a531af5bcdd29f0
ambari-agent/src/test/python/resource_management/TestUserResource.py 1598823180145d00c8657196c07e47e0c7d2da85
ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py 609271752f46d746dd62a2a36816f7ebfbac86fa
ambari-agent/src/test/python/unitTests.py b6f84116d6b3521637b178ce77b9d6943cb7c31d
Diff: https://reviews.apache.org/r/35937/diff/
Testing
-------
mvn clean test on Linux and Windows
Thanks,
Florian Barca
Re: Review Request 35937: Windows unit tests: Agent unit tests: fix
the imports & failing patches
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35937/
-----------------------------------------------------------
(Updated June 26, 2015, 9:06 p.m.)
Review request for Ambari, Artem Baranchuk and Jayush Luniya.
Summary (updated)
-----------------
Windows unit tests: Agent unit tests: fix the imports & failing patches
Bugs: AMBARI-12171
https://issues.apache.org/jira/browse/AMBARI-12171
Repository: ambari
Description
-------
Fixed the imports. Coalesced the OS mock.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestContentSources.py c144cf9fe3c977e94d0e447510bfe64849944e5c
ambari-agent/src/test/python/resource_management/TestDirectoryResource.py e57ed675580404480563f026a90ef77bc497726e
ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 6bb9d0f3ce8acfbba9d358a3595f9516299b0daa
ambari-agent/src/test/python/resource_management/TestExecuteResource.py 04244e94e6b23237a9b9a0c08a0f436e5e5f1bcd
ambari-agent/src/test/python/resource_management/TestFileResource.py 43df94f8893f83b744655f6063e4f699ae4d4596
ambari-agent/src/test/python/resource_management/TestGroupResource.py 1d52a90d7ea5012bec09cc93b4dec1062aa6b358
ambari-agent/src/test/python/resource_management/TestLinkResource.py ceac07603af7783ca4b0fd3aa7186f4f1786c7bd
ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py 5c97380ab8da2047358493b4500ff0c5d9bc0da1
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 0f3017865c215adbd6e88806e9b0fa14ac1805cb
ambari-agent/src/test/python/resource_management/TestServiceResource.py cf922784cae001fffa7490f6f0739ac0eddf035f
ambari-agent/src/test/python/resource_management/TestTemplateConfigResource.py 2808e63c82d75737d0a18e942a531af5bcdd29f0
ambari-agent/src/test/python/resource_management/TestUserResource.py 1598823180145d00c8657196c07e47e0c7d2da85
ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py 609271752f46d746dd62a2a36816f7ebfbac86fa
ambari-agent/src/test/python/unitTests.py b6f84116d6b3521637b178ce77b9d6943cb7c31d
Diff: https://reviews.apache.org/r/35937/diff/
Testing
-------
mvn clean test on Linux and Windows
Thanks,
Florian Barca