You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/10/18 23:14:14 UTC

[GitHub] gianm commented on issue #6484: Fix handling of cached data populated from result level cache (#6483)

gianm commented on issue #6484: Fix handling of cached data populated from result level cache  (#6483)
URL: https://github.com/apache/incubator-druid/pull/6484#issuecomment-431194607
 
 
   Some of the unit test failures in Travis look like query results that changed. @swapnilpandit could you please take a look at those?
   
   ```
   org.apache.druid.query.topn.TopNQueryQueryToolChestTest.testCacheStrategy(org.apache.druid.query.topn.TopNQueryQueryToolChestTest)
     Run 1: TopNQueryQueryToolChestTest.testCacheStrategy:67->doTestCacheStrategy:254 expected:<Result{timestamp=1970-01-01T00:00:00.123Z, value=TopNResultValue{value=[DimensionAndMetricValueExtractor{value={test=val1, metric1=2, post=10}}]}}> but was:<Result{timestamp=1970-01-01T00:00:00.123Z, value=TopNResultValue{value=[DimensionAndMetricValueExtractor{value={test=val1, post=2}}]}}>
     Run 2: TopNQueryQueryToolChestTest.testCacheStrategy:67->doTestCacheStrategy:254 expected:<Result{timestamp=1970-01-01T00:00:00.123Z, value=TopNResultValue{value=[DimensionAndMetricValueExtractor{value={test=val1, metric1=2, post=10}}]}}> but was:<Result{timestamp=1970-01-01T00:00:00.123Z, value=TopNResultValue{value=[DimensionAndMetricValueExtractor{value={test=val1, post=2}}]}}>
     Run 3: TopNQueryQueryToolChestTest.testCacheStrategy:67->doTestCacheStrategy:254 expected:<Result{timestamp=1970-01-01T00:00:00.123Z, value=TopNResultValue{value=[DimensionAndMetricValueExtractor{value={test=val1, metric1=2, post=10}}]}}> but was:<Result{timestamp=1970-01-01T00:00:00.123Z, value=TopNResultValue{value=[DimensionAndMetricValueExtractor{value={test=val1, post=2}}]}}>
     Run 4: TopNQueryQueryToolChestTest.testCacheStrategy:67->doTestCacheStrategy:254 expected:<Result{timestamp=1970-01-01T00:00:00.123Z, value=TopNResultValue{value=[DimensionAndMetricValueExtractor{value={test=val1, metric1=2, post=10}}]}}> but was:<Result{timestamp=1970-01-01T00:00:00.123Z, value=TopNResultValue{value=[DimensionAndMetricValueExtractor{value={test=val1, post=2}}]}}>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org