You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/29 21:50:24 UTC

[GitHub] [tvm] Wheest commented on pull request #7142: Asymmetric padding and dilation in conv2d workload

Wheest commented on pull request #7142:
URL: https://github.com/apache/tvm/pull/7142#issuecomment-752253140


   Have added all specific requested changes @comaniac, and have added tests to:
   
   **test_topi_conv2d_int8.py**
     - [x] verify_conv2d_nchw_int8
    
   **test_topi_conv2d_nchw.py**
     - [x] verify_conv2d_nchw
    
   **test_topi_depthwise_conv2d.py**
     - [x] depthwise_conv2d_with_workload_nchw 
   
   These three tests cover all the workloads that are touched by this PR.  Other data layouts use the same workload definitions.  A similar test could be added to every single conv2d test, but am unsure if that is worth it right now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org