[PR] Implement MySQLPacketPayload.writeInt6() [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #39406:
URL: https://github.com/apache/shardingsphere/pull/39406

   Write six-byte fixed-length integers in little-endian order and add wire-format coverage for high-bit and maximum values.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement MySQLPacketPayload.writeInt6() [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #39406:
URL: https://github.com/apache/shardingsphere/pull/39406#issuecomment-5248635051

   ### Result
   
   **Review Result: Mergeable**
   
   No blocking code-correctness issues were found. The implementation follows MySQL’s six-byte little-endian integer format.
   
   ### Evidence
   
   - Root cause: `writeInt6()` had remained an empty TODO implementation since 2018.
   - Implementation: It writes the lower 32 bits followed by the upper 16 bits, matching the [MySQL protocol specification](https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_basic_dt_integers.html).
   - Tests: The asymmetric high-bit value and maximum 48-bit value cover byte order, truncation, and output length.
   - Local verification: All 42 focused tests and 443 module tests passed. Spotless and Checkstyle also passed.
   
   ### Coverage
   
   - Reviewed revision: `6c99852e3a0a32ef52faeaf057227c5d17a7581d`
   - Changed scope: One production class and one test class, matching the GitHub PR file list.
   - Impact: There are currently no in-repository production callers of `writeInt6()`, so the immediate runtime impact is low. However, this fixes a public MySQL protocol-writing capability that external callers may use.
   - Reviewed root cause, protocol contract, callers, compatibility, performance, test validity, and resource lifecycle.
   - This was a code-correctness review only; CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement MySQLPacketPayload.writeInt6() [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #39406:
URL: https://github.com/apache/shardingsphere/pull/39406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org