You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/01/05 21:57:07 UTC

Review Request 64995: Improved image store manifest parsing errors.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64995/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Bugs: MESOS-8404
    https://issues.apache.org/jira/browse/MESOS-8404


Repository: mesos


Description
-------

When one of the image store backends fails to parse an image manifest,
it is most probable that the the on-disk state is incorrect. Emitting
the path in the error makes it easier for an operator to figure out
what went wrong.


Diffs
-----

  src/appc/spec.cpp 8471ccb1452662e11aac01886dcc6af81558db27 
  src/slave/containerizer/mesos/provisioner/appc/cache.cpp 09190e2c21cf39ab023ee08e12cf10610343a103 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp c4879ecfe77bbeb9ec2922831d373695aeb4e180 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp d64e6eb0f93a5d43ad756d4f0b0d1a665375dada 


Diff: https://reviews.apache.org/r/64995/diff/1/


Testing
-------

make check (Fedora 27)


Thanks,

James Peach

Re: Review Request 64995: Improved image store manifest parsing errors.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64995/#review194952
-----------------------------------------------------------



PASS: Mesos patch 64995 was successfully built and tested.

Reviews applied: `['64993', '64995']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64995

- Mesos Reviewbot Windows


On Jan. 5, 2018, 9:57 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64995/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 9:57 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8404
>     https://issues.apache.org/jira/browse/MESOS-8404
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When one of the image store backends fails to parse an image manifest,
> it is most probable that the the on-disk state is incorrect. Emitting
> the path in the error makes it easier for an operator to figure out
> what went wrong.
> 
> 
> Diffs
> -----
> 
>   src/appc/spec.cpp 8471ccb1452662e11aac01886dcc6af81558db27 
>   src/slave/containerizer/mesos/provisioner/appc/cache.cpp 09190e2c21cf39ab023ee08e12cf10610343a103 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp c4879ecfe77bbeb9ec2922831d373695aeb4e180 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp d64e6eb0f93a5d43ad756d4f0b0d1a665375dada 
> 
> 
> Diff: https://reviews.apache.org/r/64995/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>