You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/21 03:09:56 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

AngersZhuuuu opened a new pull request #32264:
URL: https://github.com/apache/spark/pull/32264


   ### What changes were proposed in this pull request?
   Extract common doc about hive format for `sql-ref-syntax-ddl-create-table-hiveformat.md` and `sql-ref-syntax-qry-select-transform.md` to refer.
   
   ### Why are the changes needed?
   Improve doc
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Not need
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

maropu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824923282


   NOTE: I'm planning to backport this PR and https://github.com/apache/spark/pull/31010 into branch-3.1/3.0 because I think these document pages are useful for users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

maropu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825409275


   They have different jira tickets, so I think its better to bckport them separately. Could you? @AngersZhuuuu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824722358






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825317342


   **[Test build #137837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137837/testReport)** for PR 32264 at commit [`9bfa1cf`](https://github.com/apache/spark/commit/9bfa1cfe7e865ea4f3fa6c8d75b0ce0b22388bf9).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

maropu commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618475129



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval

Review comment:
       `Data Retrieval` -> `Hive Row Format`?

##########
File path: docs/sql-ref-syntax-qry-select-transform.md
##########
@@ -49,45 +41,9 @@ row_format:
     
     Specifies a combination of one or more values, operators and SQL functions that results in a value.
 
-* **row_format**    
-
-    Otherwise, uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
-
-* **SERDE**
-
-    Specifies a custom SerDe for one table.
-
-* **serde_class**
-
-    Specifies a fully-qualified class name of a custom SerDe.
-
-* **DELIMITED**
-
-    The `DELIMITED` clause can be used to specify the native SerDe and state the delimiter, escape character, null character and so on.
-
-* **FIELDS TERMINATED BY**
-
-    Used to define a column separator.
-    
-* **COLLECTION ITEMS TERMINATED BY**
-
-    Used to define a collection item separator.
-   
-* **MAP KEYS TERMINATED BY**
-
-    Used to define a map key separator.
-    
-* **LINES TERMINATED BY**
-
-    Used to define a row separator.
-    
-* **NULL DEFINED AS**
-
-    Used to define the specific value for NULL.
-    
-* **ESCAPED BY**
+* **row_format** 
 
-    Used for escape mechanism.
+    All descriptions about syntax in `row_format` can refer to [HIVE FORMAT](sql-ref-syntax-hive-format.html)

Review comment:
       ditto

##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,

Review comment:
       "`CREATE TABLE` clause and `TRANSFORM` clause" => "`CREATE TABLE` and `TRANSFORM` clauses"?

##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -82,50 +74,10 @@ as any order. For example, you can write COMMENT table_comment after TBLPROPERTI
 * **INTO num_buckets BUCKETS**
 
     Specifies buckets numbers, which is used in `CLUSTERED BY` clause.
-    
-* **row_format**    
-
-    Use the `SERDE` clause to specify a custom SerDe for one table. Otherwise, use the `DELIMITED` clause to use the native SerDe and specify the delimiter, escape character, null character and so on.
-    
-* **SERDE**
-
-    Specifies a custom SerDe for one table.
-    
-* **serde_class**
-
-    Specifies a fully-qualified class name of a custom SerDe.
-
-* **SERDEPROPERTIES**
-
-    A list of key-value pairs that is used to tag the SerDe definition.
-    
-* **DELIMITED**
 
-    The `DELIMITED` clause can be used to specify the native SerDe and state the delimiter, escape character, null character and so on.
-    
-* **FIELDS TERMINATED BY**
-
-    Used to define a column separator.
-    
-* **COLLECTION ITEMS TERMINATED BY**
-
-    Used to define a collection item separator.
-   
-* **MAP KEYS TERMINATED BY**
-
-    Used to define a map key separator.
-    
-* **LINES TERMINATED BY**
-
-    Used to define a row separator.
-    
-* **NULL DEFINED AS**
-
-    Used to define the specific value for NULL.
-    
-* **ESCAPED BY**
+* **row_format** 
 
-    Used for escape mechanism.
+    All descriptions about syntax in `row_format` can refer to [HIVE FORMAT](sql-ref-syntax-hive-format.html)

Review comment:
       How about `Specifies the row format for input and output. See [HIVE ROW FORMAT](...) for more syntax details.`?

##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,

Review comment:
       `Hive format` -> `a Hive row format`

##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,

Review comment:
       ```
   There are two ways to define a row format in `row_format` of `CREATE TABLE` and `TRANSFORM` clauses.
     1. `SERDE` clause to specify a custom SerDe class.
     2. `DELIMITED` clause to specify a delimiter, an escape character, a null character, and so on for the native SerDe.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

maropu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-826606867


   yea, yes. I couldn't cherry-pick them into the previous branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825317477


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137837/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823983157


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42259/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823975175


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137732/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824669648


   @maropu do you want to take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825335511


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42367/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823759465






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825329129


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42367/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825404041


   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823746426


   **[Test build #137711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137711/testReport)** for PR 32264 at commit [`d98f825`](https://github.com/apache/spark/commit/d98f82521a505b14d04bafd63191c033a3443bb3).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823760238






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823983104






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823745554


   **[Test build #137710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137710/testReport)** for PR 32264 at commit [`df246ea`](https://github.com/apache/spark/commit/df246eaa94a6e30f799dd8376f9eca378f2e31fe).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618173472



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
+to specify serde or text delimeter. In `row_format`, uses the `SERDE` clause to specify a custom SerDe

Review comment:
       In `row_format`, uses  ->  `row_format` uses




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823749761


   **[Test build #137711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137711/testReport)** for PR 32264 at commit [`d98f825`](https://github.com/apache/spark/commit/d98f82521a505b14d04bafd63191c033a3443bb3).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

maropu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-826601259


   > They have different jira tickets, so I think its better to backport them separately. Could you? @AngersZhuuuu
   
   ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r617286498



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,83 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark support Hive format in `CREATE TABLE` clause and `TRANSFORM` clause, Hive format support 
+`SERDE` and native `DELIMITED`.
+
+### Syntax
+
+```sql
+row_format:    
+    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+    | DELIMITED [ FIELDS TERMINATED BY fields_terminated_char [ ESCAPED BY escaped_char ] ] 
+        [ COLLECTION ITEMS TERMINATED BY collection_items_terminated_char ] 
+        [ MAP KEYS TERMINATED BY map_key_terminated_char ]
+        [ LINES TERMINATED BY row_terminated_char ]
+        [ NULL DEFINED AS null_char ]
+```
+
+### Parameters
+
+* **row_format**    
+
+    Use the `SERDE` clause to specify a custom SerDe for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause to use the native SerDe and specify the delimiter, escape character, null character and so on.

Review comment:
       shall we put it in `Description` at the beginning?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824722404


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42326/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823983157


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42259/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823748951


   **[Test build #137710 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137710/testReport)** for PR 32264 at commit [`df246ea`](https://github.com/apache/spark/commit/df246eaa94a6e30f799dd8376f9eca378f2e31fe).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823958550


   **[Test build #137732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137732/testReport)** for PR 32264 at commit [`203f544`](https://github.com/apache/spark/commit/203f544d637cf9668998cbb018eb38bfd585ebdb).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823760887






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823745554


   **[Test build #137710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137710/testReport)** for PR 32264 at commit [`df246ea`](https://github.com/apache/spark/commit/df246eaa94a6e30f799dd8376f9eca378f2e31fe).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825327471


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42367/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825404433


   @maropu shall we have a single backport PR or two?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825404240


   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

maropu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824921262


   Could you add the screenshot of the new page in the PR description?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AngersZhuuuu commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r617395294



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,83 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark support Hive format in `CREATE TABLE` clause and `TRANSFORM` clause, Hive format support 

Review comment:
       Done

##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,83 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark support Hive format in `CREATE TABLE` clause and `TRANSFORM` clause, Hive format support 
+`SERDE` and native `DELIMITED`.
+
+### Syntax
+
+```sql
+row_format:    
+    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+    | DELIMITED [ FIELDS TERMINATED BY fields_terminated_char [ ESCAPED BY escaped_char ] ] 
+        [ COLLECTION ITEMS TERMINATED BY collection_items_terminated_char ] 
+        [ MAP KEYS TERMINATED BY map_key_terminated_char ]
+        [ LINES TERMINATED BY row_terminated_char ]
+        [ NULL DEFINED AS null_char ]
+```
+
+### Parameters
+
+* **row_format**    
+
+    Use the `SERDE` clause to specify a custom SerDe for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause to use the native SerDe and specify the delimiter, escape character, null character and so on.

Review comment:
       Done

##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,83 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark support Hive format in `CREATE TABLE` clause and `TRANSFORM` clause, Hive format support 
+`SERDE` and native `DELIMITED`.
+
+### Syntax
+
+```sql
+row_format:    
+    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+    | DELIMITED [ FIELDS TERMINATED BY fields_terminated_char [ ESCAPED BY escaped_char ] ] 
+        [ COLLECTION ITEMS TERMINATED BY collection_items_terminated_char ] 
+        [ MAP KEYS TERMINATED BY map_key_terminated_char ]
+        [ LINES TERMINATED BY row_terminated_char ]
+        [ NULL DEFINED AS null_char ]
+```
+
+### Parameters
+
+* **row_format**    
+
+    Use the `SERDE` clause to specify a custom SerDe for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause to use the native SerDe and specify the delimiter, escape character, null character and so on.
+    
+* **SERDE**

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824676292


   **[Test build #137797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137797/testReport)** for PR 32264 at commit [`5fe64b5`](https://github.com/apache/spark/commit/5fe64b575b8aed7d050e1e9959dbfc134f8b9345).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618176733



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
+to specify serde or text delimeter. In `row_format`, uses the `SERDE` clause to specify a custom SerDe
+for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause
+to use the native SerDe and specify the delimiter, escape character, null character and so on.
+
+### Syntax
+
+```sql
+row_format:    
+    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+    | DELIMITED [ FIELDS TERMINATED BY fields_terminated_char [ ESCAPED BY escaped_char ] ] 
+        [ COLLECTION ITEMS TERMINATED BY collection_items_terminated_char ] 
+        [ MAP KEYS TERMINATED BY map_key_terminated_char ]
+        [ LINES TERMINATED BY row_terminated_char ]
+        [ NULL DEFINED AS null_char ]
+```
+
+### Parameters
+   
+* **SERDE serde_class**
+
+    Specifies a fully-qualified class name of custom SerDe for one table or processing inputs and outputs data.
+
+* **SERDEPROPERTIES**
+
+    A list of key-value pairs that is used to tag the SerDe definition.
+    
+* **DELIMITED**

Review comment:
       We can remove this, as it's already covered in the `Description` section




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AngersZhuuuu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825307388


   > Could you add the screenshot of the new page in the PR description?
   
   DOne


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

maropu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825410493


   Anyway, late lgtm. Thank you, @AngersZhuuuu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r617287029



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,83 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark support Hive format in `CREATE TABLE` clause and `TRANSFORM` clause, Hive format support 
+`SERDE` and native `DELIMITED`.
+
+### Syntax
+
+```sql
+row_format:    
+    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+    | DELIMITED [ FIELDS TERMINATED BY fields_terminated_char [ ESCAPED BY escaped_char ] ] 
+        [ COLLECTION ITEMS TERMINATED BY collection_items_terminated_char ] 
+        [ MAP KEYS TERMINATED BY map_key_terminated_char ]
+        [ LINES TERMINATED BY row_terminated_char ]
+        [ NULL DEFINED AS null_char ]
+```
+
+### Parameters
+
+* **row_format**    
+
+    Use the `SERDE` clause to specify a custom SerDe for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause to use the native SerDe and specify the delimiter, escape character, null character and so on.
+    
+* **SERDE**

Review comment:
       we can merge this with the next one. `SERDE  serde_class`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618047623



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval

Review comment:
       In this case, shall we add a reference to this `sql-ref-syntax-hive-format.md` into `sql-ref-syntax-qry.md`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824687224


   **[Test build #137797 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137797/testReport)** for PR 32264 at commit [`5fe64b5`](https://github.com/apache/spark/commit/5fe64b575b8aed7d050e1e9959dbfc134f8b9345).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825313680


   **[Test build #137837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137837/testReport)** for PR 32264 at commit [`9bfa1cf`](https://github.com/apache/spark/commit/9bfa1cfe7e865ea4f3fa6c8d75b0ce0b22388bf9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618175628



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
+to specify serde or text delimeter. In `row_format`, uses the `SERDE` clause to specify a custom SerDe
+for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause
+to use the native SerDe and specify the delimiter, escape character, null character and so on.

Review comment:
       how about this
   ```
   There are two ways to specify the `row_format`:
   1. Use the `SERDE` clause to specify a custom SerDe class
   2. Use the `DELIMITED` clause to specify the delimiter ... and so on for the native text Serde.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825317477


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137837/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618047623



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval

Review comment:
       ~In this case, shall we add a reference to this `sql-ref-syntax-hive-format.md` into `sql-ref-syntax-qry.md`?~
   
   Oh, got it. I saw @cloud-fan 's comment, `We don't need to put it in the menu page`. Nvm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824722404


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42326/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AngersZhuuuu commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618055912



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval

Review comment:
       Yea, refer this in other menu doc is so strange and it's refer in two syntax doc with different type. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AngersZhuuuu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-826604786


   > > They have different jira tickets, so I think its better to backport them separately. Could you? @AngersZhuuuu
   > 
   > ping
   
   Hmmm,  have conflict? need me to create backport PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823975175


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137732/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824676292


   **[Test build #137797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137797/testReport)** for PR 32264 at commit [`5fe64b5`](https://github.com/apache/spark/commit/5fe64b575b8aed7d050e1e9959dbfc134f8b9345).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823760909


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42238/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823746426


   **[Test build #137711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137711/testReport)** for PR 32264 at commit [`d98f825`](https://github.com/apache/spark/commit/d98f82521a505b14d04bafd63191c033a3443bb3).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618176182



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
+to specify serde or text delimeter. In `row_format`, uses the `SERDE` clause to specify a custom SerDe
+for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause
+to use the native SerDe and specify the delimiter, escape character, null character and so on.
+
+### Syntax
+
+```sql
+row_format:    
+    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+    | DELIMITED [ FIELDS TERMINATED BY fields_terminated_char [ ESCAPED BY escaped_char ] ] 
+        [ COLLECTION ITEMS TERMINATED BY collection_items_terminated_char ] 
+        [ MAP KEYS TERMINATED BY map_key_terminated_char ]
+        [ LINES TERMINATED BY row_terminated_char ]
+        [ NULL DEFINED AS null_char ]
+```
+
+### Parameters
+   
+* **SERDE serde_class**
+
+    Specifies a fully-qualified class name of custom SerDe for one table or processing inputs and outputs data.

Review comment:
       nit: We can remove `for one table or processing inputs and outputs data.` which looks a bit weird.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AngersZhuuuu commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618196412



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
+to specify serde or text delimeter. In `row_format`, uses the `SERDE` clause to specify a custom SerDe
+for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause
+to use the native SerDe and specify the delimiter, escape character, null character and so on.
+
+### Syntax
+
+```sql
+row_format:    
+    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+    | DELIMITED [ FIELDS TERMINATED BY fields_terminated_char [ ESCAPED BY escaped_char ] ] 
+        [ COLLECTION ITEMS TERMINATED BY collection_items_terminated_char ] 
+        [ MAP KEYS TERMINATED BY map_key_terminated_char ]
+        [ LINES TERMINATED BY row_terminated_char ]
+        [ NULL DEFINED AS null_char ]
+```
+
+### Parameters
+   
+* **SERDE serde_class**
+
+    Specifies a fully-qualified class name of custom SerDe for one table or processing inputs and outputs data.
+
+* **SERDEPROPERTIES**
+
+    A list of key-value pairs that is used to tag the SerDe definition.
+    
+* **DELIMITED**

Review comment:
       Done

##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
+to specify serde or text delimeter. In `row_format`, uses the `SERDE` clause to specify a custom SerDe
+for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause
+to use the native SerDe and specify the delimiter, escape character, null character and so on.
+
+### Syntax
+
+```sql
+row_format:    
+    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+    | DELIMITED [ FIELDS TERMINATED BY fields_terminated_char [ ESCAPED BY escaped_char ] ] 
+        [ COLLECTION ITEMS TERMINATED BY collection_items_terminated_char ] 
+        [ MAP KEYS TERMINATED BY map_key_terminated_char ]
+        [ LINES TERMINATED BY row_terminated_char ]
+        [ NULL DEFINED AS null_char ]
+```
+
+### Parameters
+   
+* **SERDE serde_class**
+
+    Specifies a fully-qualified class name of custom SerDe for one table or processing inputs and outputs data.

Review comment:
       Done

##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
+to specify serde or text delimeter. In `row_format`, uses the `SERDE` clause to specify a custom SerDe
+for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause
+to use the native SerDe and specify the delimiter, escape character, null character and so on.

Review comment:
       Year, more clear

##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,77 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
+to specify serde or text delimeter. In `row_format`, uses the `SERDE` clause to specify a custom SerDe

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan closed pull request #32264:
URL: https://github.com/apache/spark/pull/32264


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825335511


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42367/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu edited a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

maropu edited a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825409275


   They have different jira tickets, so I think its better to backport them separately. Could you? @AngersZhuuuu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AngersZhuuuu commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618845681



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,

Review comment:
       Done

##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -82,50 +74,10 @@ as any order. For example, you can write COMMENT table_comment after TBLPROPERTI
 * **INTO num_buckets BUCKETS**
 
     Specifies buckets numbers, which is used in `CLUSTERED BY` clause.
-    
-* **row_format**    
-
-    Use the `SERDE` clause to specify a custom SerDe for one table. Otherwise, use the `DELIMITED` clause to use the native SerDe and specify the delimiter, escape character, null character and so on.
-    
-* **SERDE**
-
-    Specifies a custom SerDe for one table.
-    
-* **serde_class**
-
-    Specifies a fully-qualified class name of a custom SerDe.
-
-* **SERDEPROPERTIES**
-
-    A list of key-value pairs that is used to tag the SerDe definition.
-    
-* **DELIMITED**
 
-    The `DELIMITED` clause can be used to specify the native SerDe and state the delimiter, escape character, null character and so on.
-    
-* **FIELDS TERMINATED BY**
-
-    Used to define a column separator.
-    
-* **COLLECTION ITEMS TERMINATED BY**
-
-    Used to define a collection item separator.
-   
-* **MAP KEYS TERMINATED BY**
-
-    Used to define a map key separator.
-    
-* **LINES TERMINATED BY**
-
-    Used to define a row separator.
-    
-* **NULL DEFINED AS**
-
-    Used to define the specific value for NULL.
-    
-* **ESCAPED BY**
+* **row_format** 
 
-    Used for escape mechanism.
+    All descriptions about syntax in `row_format` can refer to [HIVE FORMAT](sql-ref-syntax-hive-format.html)

Review comment:
       Done

##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-825313680


   **[Test build #137837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137837/testReport)** for PR 32264 at commit [`9bfa1cf`](https://github.com/apache/spark/commit/9bfa1cfe7e865ea4f3fa6c8d75b0ce0b22388bf9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r617285660



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,83 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark support Hive format in `CREATE TABLE` clause and `TRANSFORM` clause, Hive format support 

Review comment:
       ```
   Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
   to specify serde or text delimeter.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AngersZhuuuu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-826630317


   > yea, yes. I couldn't cherry-pick them into the previous branches.
   
   Ok, ping you later when PR is ready


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823860502


   > not sure if we need to put this page in which menu page
   
   We don't need to put it in the menu page.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

cloud-fan commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r617287029



##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,83 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--
+
+### Description
+
+Spark support Hive format in `CREATE TABLE` clause and `TRANSFORM` clause, Hive format support 
+`SERDE` and native `DELIMITED`.
+
+### Syntax
+
+```sql
+row_format:    
+    SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+    | DELIMITED [ FIELDS TERMINATED BY fields_terminated_char [ ESCAPED BY escaped_char ] ] 
+        [ COLLECTION ITEMS TERMINATED BY collection_items_terminated_char ] 
+        [ MAP KEYS TERMINATED BY map_key_terminated_char ]
+        [ LINES TERMINATED BY row_terminated_char ]
+        [ NULL DEFINED AS null_char ]
+```
+
+### Parameters
+
+* **row_format**    
+
+    Use the `SERDE` clause to specify a custom SerDe for one table or processing inputs and outputs data. Otherwise, use the `DELIMITED` clause to use the native SerDe and specify the delimiter, escape character, null character and so on.
+    
+* **SERDE**

Review comment:
       we can remove this. `serde_class` should be the place to put the doc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AngersZhuuuu commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823746928


   I am not sure if we need to put this page in which menu page 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823760909


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42238/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823760238






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823948694


   **[Test build #137732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137732/testReport)** for PR 32264 at commit [`203f544`](https://github.com/apache/spark/commit/203f544d637cf9668998cbb018eb38bfd585ebdb).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824712738


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137797/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-823948694


   **[Test build #137732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137732/testReport)** for PR 32264 at commit [`203f544`](https://github.com/apache/spark/commit/203f544d637cf9668998cbb018eb38bfd585ebdb).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #32264:
URL: https://github.com/apache/spark/pull/32264#issuecomment-824712738


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137797/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org