You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/08 01:50:00 UTC
[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #1140: feat: support endpointslice, and improve test/e2e/endpoints.go tests.
AlinsRan opened a new pull request, #1140:
URL: https://github.com/apache/apisix-ingress-controller/pull/1140
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1140: feat: support endpointslice, and improve test/e2e/endpoints.go tests.
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1140:
URL: https://github.com/apache/apisix-ingress-controller/pull/1140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1140: feat: support endpointslice, and improve test/e2e/endpoints.go tests.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1140:
URL: https://github.com/apache/apisix-ingress-controller/pull/1140#issuecomment-1178449547
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1140](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8e9655) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/e25abdb2be54865be03a7d486960e9c77eb1ba86?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e25abdb) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #1140 +/- ##
==========================================
- Coverage 30.38% 30.35% -0.04%
==========================================
Files 81 81
Lines 9409 9419 +10
==========================================
Hits 2859 2859
- Misses 6235 6245 +10
Partials 315 315
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/ingress/endpointslice.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnRzbGljZS5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `66.34% <0.00%> (ø)` | |
| [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | `39.73% <0.00%> (ø)` | |
| [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `37.33% <0.00%> (ø)` | |
| [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e25abdb...b8e9655](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1140?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1140: feat: support endpointslice, and improve test/e2e/endpoints.go tests.
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on code in PR #1140:
URL: https://github.com/apache/apisix-ingress-controller/pull/1140#discussion_r916638751
##########
test/e2e/suite-endpoints/endpoints.go:
##########
@@ -21,17 +21,27 @@ import (
ginkgo "github.com/onsi/ginkgo/v2"
"github.com/stretchr/testify/assert"
+ "k8s.io/apimachinery/pkg/util/wait"
"github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
)
+func ensureNumListUpstreamNodes(s *scaffold.Scaffold, upsNum int, upsNodesNum int) error {
Review Comment:
I think this function could be a public scaffold function instead of a package private one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1140: feat: support endpointslice, and improve test/e2e/endpoints.go tests.
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1140:
URL: https://github.com/apache/apisix-ingress-controller/pull/1140#discussion_r916614137
##########
test/e2e/suite-endpoints/endpoints.go:
##########
@@ -21,17 +21,27 @@ import (
ginkgo "github.com/onsi/ginkgo/v2"
"github.com/stretchr/testify/assert"
+ "k8s.io/apimachinery/pkg/util/wait"
"github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
)
+func ensureNumListUpstreamNodes(s *scaffold.Scaffold, upsNum int, upsNodesNum int) error {
+ condFunc := func() (bool, error) {
+ ups, err := s.ListApisixUpstreams()
+ if err != nil || len(ups) != upsNum || len(ups[0].Nodes) != upsNodesNum {
Review Comment:
I thought it would be better to add some comments here.
such as expected return values, data structures and examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org